Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

improve-codebase-architecture: intended end-state — does an *accepted* candidate hand off to to-issues, or stop at CONTEXT.md/ADRs? #287

Unanswered
erikpr1994 asked this question in Q&A
Discussion options

Loving this skill. One thing I can't pin down from SKILL.md, DEEPENING.md, or the README: what's the intended terminal state of the grilling loop when a deepening candidate is accepted?

What I can read from the source:

  • The grilling loop's documented side effects are CONTEXT.md updates and (sparingly) ADRs, plus optional INTERFACE-DESIGN.md. DEEPENING.md covers the testing/seam strategy. The skill never writes the implementation itself.
  • There's an explicit side effect for a rejected candidate (offer an ADR so future reviews don't re-suggest it), but none documented for an accepted one.

My questions:

  1. Is the loop intended to terminate at design + docs (CONTEXT.md/ADRs), leaving implementation as a fully separate, manual step?
  2. For an accepted candidate, is the intended next step to invoke to-issues / to-prd to track the refactor, or is tracking deliberately out of scope for this skill? The README doesn't document how the skills compose, and to-issues doesn't name this skill as an upstream step.
  3. If a handoff is intended, would you take a PR adding a short 'next steps' note to SKILL.md?

Thanks!

You must be logged in to vote

Replies: 0 comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
1 participant

AltStyle によって変換されたページ (->オリジナル) /