-
Notifications
You must be signed in to change notification settings - Fork 11.2k
improve-codebase-architecture: intended end-state — does an *accepted* candidate hand off to to-issues, or stop at CONTEXT.md/ADRs? #287
Unanswered
erikpr1994
asked this question in
Q&A
-
Loving this skill. One thing I can't pin down from SKILL.md, DEEPENING.md, or the README: what's the intended terminal state of the grilling loop when a deepening candidate is accepted?
What I can read from the source:
- The grilling loop's documented side effects are CONTEXT.md updates and (sparingly) ADRs, plus optional INTERFACE-DESIGN.md. DEEPENING.md covers the testing/seam strategy. The skill never writes the implementation itself.
- There's an explicit side effect for a rejected candidate (offer an ADR so future reviews don't re-suggest it), but none documented for an accepted one.
My questions:
- Is the loop intended to terminate at design + docs (CONTEXT.md/ADRs), leaving implementation as a fully separate, manual step?
- For an accepted candidate, is the intended next step to invoke
to-issues/to-prdto track the refactor, or is tracking deliberately out of scope for this skill? The README doesn't document how the skills compose, andto-issuesdoesn't name this skill as an upstream step. - If a handoff is intended, would you take a PR adding a short 'next steps' note to SKILL.md?
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment