-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Deprecate setting text kerning factor to any non-None value #30322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
76132af to
30280d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to remove this plot from the old what's new, as it will no longer show any difference between it and the plot below (with the correct results) once we switch to libraqm, and so it might be misleading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This being 1 seems to have been a typo. Since the test checks relative results, it made no difference here.
The rcParams depreciation machinery was removed per #29563. But you can still dreprecate rcParams if you want to
just write custom deprecation logic into setitem/getitem and add corresponding tests whenever we want to deprecate a rcparam...
30280d0 to
99d357f
Compare
OK, I've added a deprecation for the rcParam directly, then.
99d357f to
779af59
Compare
This factor existed only to preserve test images, but as of matplotlib#29816, it is set to 0 (i.e., disabled and providing default behaviour). In the future, with libraqm, it will have no effect no matter its setting (because we won't be applying kerning ourselves at all.)
779af59 to
42c108a
Compare
42c108a
into
matplotlib:text-overhaul
PR summary
This factor existed only to preserve test images, but as of #29816, it is set to 0 (i.e., disabled and providing default behaviour). In the future, with libraqm, it will have no effect no matter its setting (because we won't be applying kerning ourselves at all.)
Since we seem to have removed most of the rcParam deprecation machinery, instead of warning from there, warn from the
FT2Fontconstructor, which is always passed_kerning_factorin the normal code path (i.e., anywhere outside of direct tests.) This does mean the warning won't occur directly where you set it, nor if you don't use any text, but I think that's a reasonable compromise.PR checklist