Commit 0ed1667

committed

Rename "suggested" posts to "featured" so we can use suggested as many=True

1 parent 63a2b36 commit 0ed1667Copy full SHA for 0ed1667

File tree

2 files changed

-9

lines changed

example
- serializers.py
- tests/integration
  - test_includes.py

2 files changed

-9

lines changed

`‎example/serializers.py‎`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -25,25 +25,25 @@ class EntrySerializer(serializers.ModelSerializer):`
`25`	`25`
`26`	`26`	`def __init__(self, args, *kwargs):`
`27`	`27`	`# to make testing more concise we'll only output the`
`28`		- # `suggested` field when it's requested via `include`
	`28`	+ # `featured` field when it's requested via `include`
`29`	`29`	`request = kwargs.get('context', {}).get('request')`
`30`		`- if request and 'suggested' not in request.query_params.get('include', []):`
`31`		`- self.fields.pop('suggested')`
	`30`	`+ if request and 'featured' not in request.query_params.get('include', []):`
	`31`	`+ self.fields.pop('featured')`
`32`	`32`	`super(EntrySerializer, self).__init__(args, *kwargs)`
`33`	`33`
`34`	`34`	`included_serializers = {`
`35`	`35`	`'authors': 'example.serializers.AuthorSerializer',`
`36`	`36`	`'comments': 'example.serializers.CommentSerializer',`
`37`		`- 'suggested': 'example.serializers.EntrySerializer',`
	`37`	`+ 'featured': 'example.serializers.EntrySerializer',`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`body_format = serializers.SerializerMethodField()`
`41`	`41`	`comments = relations.ResourceRelatedField(`
`42`	`42`	`source='comment_set', many=True, read_only=True)`
`43`		`- suggested = relations.SerializerMethodResourceRelatedField(`
`44`		`- source='get_suggested', model=Entry, read_only=True)`
	`43`	`+ featured = relations.SerializerMethodResourceRelatedField(`
	`44`	`+ source='get_featured', model=Entry, read_only=True)`
`45`	`45`
`46`		`- def get_suggested(self, obj):`
	`46`	`+ def get_featured(self, obj):`
`47`	`47`	`return Entry.objects.exclude(pk=obj.pk).first()`
`48`	`48`
`49`	`49`	`def get_body_format(self, obj):`
`@@ -52,7 +52,7 @@ def get_body_format(self, obj):`
`52`	`52`	`class Meta:`
`53`	`53`	`model = Entry`
`54`	`54`	`fields = ('blog', 'headline', 'body_text', 'pub_date', 'mod_date',`
`55`		`- 'authors', 'comments', 'suggested',)`
	`55`	`+ 'authors', 'comments', 'featured',)`
`56`	`56`	`meta_fields = ('body_format',)`
`57`	`57`
`58`	`58`

`‎example/tests/integration/test_includes.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ def test_included_data_on_detail(single_entry, client):`
`31`	`31`
`32`	`32`	`def test_dynamic_related_data_is_included(single_entry, entry_factory, client):`
`33`	`33`	`entry_factory()`
`34`		`- response = client.get(reverse("entry-detail", kwargs={'pk': single_entry.pk}) + '?include=suggested')`
	`34`	`+ response = client.get(reverse("entry-detail", kwargs={'pk': single_entry.pk}) + '?include=featured')`
`35`	`35`	`included = load_json(response.content).get('included')`
`36`	`36`
`37`	`37`	`assert [x.get('type') for x in included] == ['entries'], 'Dynamic included types are incorrect'`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 0ed1667

File tree

2 files changed

2 files changed

`‎example/serializers.py‎`

`‎example/tests/integration/test_includes.py‎`

0 commit comments