Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 03f9003

Browse files
2880: static fixes 6
1 parent 588a321 commit 03f9003

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

‎src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/NewCustomerEavAttributeDialog.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@
5050
"PMD.TooManyFields",
5151
"PMD.ExcessiveImports",
5252
"PMD.TooManyMethods",
53-
"PMD.UnusedPrivateField"
53+
"PMD.UnusedPrivateField",
54+
"PMD.GodClass"
5455
})
5556
public class NewCustomerEavAttributeDialog extends AbstractDialog {
5657

@@ -173,6 +174,7 @@ protected void initDialogState() {
173174
/**
174175
* Fill attribute type combo box.
175176
*/
177+
@SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
176178
protected void fillAttributeTypeComboBox() {
177179
if (typeComboBox == null) {
178180
return;
@@ -188,6 +190,7 @@ protected void fillAttributeTypeComboBox() {
188190
/**
189191
* Fill attribute input combo box.
190192
*/
193+
@SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
191194
protected void fillAttributeInputComboBox() {
192195
if (inputComboBox == null) {
193196
return;
@@ -540,7 +543,11 @@ protected void generateExtraFilesBeforeDataPatchGeneration() {
540543
*/
541544
protected void generateExtraFilesAfterDataPatchGeneration(
542545
final EavEntityDataInterface eavEntityDataInterface
543-
) {}
546+
) {
547+
// This method is intentionally left empty.
548+
// No additional files need to be generated after the data patch for customer EAV attributes.
549+
// Subclasses may override this method to provide specific implementation if needed.
550+
}
544551

545552
/**
546553
* Create center panel.

‎src/main/java/com/magento/idea/magento2plugin/actions/generation/dialog/NewProductEavAttributeDialog.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@
5656
"PMD.TooManyFields",
5757
"PMD.ExcessiveImports",
5858
"PMD.TooManyMethods",
59-
"PMD.UnusedPrivateField"
59+
"PMD.UnusedPrivateField",
60+
"PMD.GodClass"
6061
})
6162
public class NewProductEavAttributeDialog extends AbstractDialog {
6263

@@ -189,6 +190,7 @@ protected void initDialogState() {
189190
/**
190191
* Fill attribute type combo box.
191192
*/
193+
@SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
192194
protected void fillAttributeTypeComboBox() {
193195
if (typeComboBox == null) {
194196
return;
@@ -204,6 +206,7 @@ protected void fillAttributeTypeComboBox() {
204206
/**
205207
* Fill attribute input combo box.
206208
*/
209+
@SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
207210
protected void fillAttributeInputComboBox() {
208211
if (inputComboBox == null) {
209212
return;
@@ -587,7 +590,11 @@ protected void generateExtraFilesBeforeDataPatchGeneration() {
587590
*/
588591
protected void generateExtraFilesAfterDataPatchGeneration(
589592
final EavEntityDataInterface eavEntityDataInterface
590-
) {}
593+
) {
594+
// This method is intentionally left empty.
595+
// No additional files need to be generated after the data patch for product EAV attributes.
596+
// Subclasses may override this method to provide specific implementation if needed.
597+
}
591598

592599
/**
593600
* Create center panel.

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /