-
Notifications
You must be signed in to change notification settings - Fork 218
Take an interface for http.Client #33
Open
Description
It would be nice if https://github.com/machinebox/graphql/blob/master/graphql.go#L48 could take a Doer interface, compatible with the std lib *http.Client so that clients can pass in whatever http client they want:
type Doer interface { Do(req *http.Request) (*http.Response, error) }
This shouldn't break any clients using the std lib today.
I'd be happy to create a PR if you don't see any issue with the change.
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Give feedbackNo fields configured for issues without a type.