Commit c8b9c18

committed

fixed infinite loop for js queries

1 parent 5567f0a commit c8b9c18Copy full SHA for c8b9c18

File tree

-1

lines changed

client/packages/lowcoder/src/comps
- controls/actionSelector
  - executeQueryAction.tsx
- queries
  - queryComp.tsx

-1

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,9 @@ const ExecuteQueryPropertyView = ({`
`56`	`56`	`}, [placement]);`
`57`	`57`
`58`	`58`	`const getVariableOptions = useCallback((editorState?: EditorState) => {`
	`59`	`+ const queryVariables = comp.children.queryVariables.getView();`
	`60`	`+ if (!queryVariables.length) return null;`
	`61`	`+`
`59`	`62`	`return comp.children.queryVariables.propertyView({`
`60`	`63`	`label: trans("eventHandler.queryVariables"),`
`61`	`64`	`layout: "vertical",`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -259,7 +259,11 @@ QueryCompTmp = class extends QueryCompTmp {`
`259`	`259`	`\|\| isInputChangeTrigger`
`260`	`260`	`\|\| (isPageLoadTrigger && notExecuted)`
`261`	`261`	`)`
`262`		`- // && (!isJsQuery \|\| (isJsQuery && notExecuted)) // query which has deps can be executed on page load(first time)`
	`262`	`+ && (`
	`263`	`+ !isJsQuery`
	`264`	`+ \|\| (isJsQuery && !isAutomatic)`
	`265`	`+ \|\| (isJsQuery && isAutomatic && notExecuted)`
	`266`	`+ ) // query which has deps can be executed on page load(first time)`
`263`	`267`	`) {`
`264`	`268`	`const next = super.reduce(action);`
`265`	`269`	`const depends = this.children.comp.node()?.dependValues();`

Comments

(0)