Commit 2ee3c48

committed

reduced actions for global variables

1 parent ad3733a commit 2ee3c48Copy full SHA for 2ee3c48

File tree

+20

-11

lines changed

+20

-11

lines changed

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -36,9 +36,11 @@ export function hookToStateComp(useHookFn: () => JSONObject) {`
`36`	`36`	`const hookValue = useHookFn();`
`37`	`37`	`const stateValue = useMemo(() => comp.children.stateValue.getView(), [comp.children.stateValue]);`
`38`	`38`
`39`		`- if (!isEqual(hookValue, stateValue)) {`
`40`		`- comp.children.stateValue.dispatchChangeValueAction(hookValue);`
`41`		`- }`
	`39`	`+ useEffect(() => {`
	`40`	`+ if (!isEqual(hookValue, stateValue)) {`
	`41`	`+ comp.children.stateValue.dispatchChangeValueAction(hookValue);`
	`42`	`+ }`
	`43`	`+ }, [hookValue, stateValue]);`
`42`	`44`	`return null;`
`43`	`45`	`}`
`44`	`46`	`);`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,9 @@ type ScreenInfo = {`
`22`	`22`	`export function useScreenInfo() {`
`23`	`23`	`const canvasContainer = document.getElementById(CanvasContainerID);`
`24`	`24`	`const canvas = document.getElementsByClassName('lowcoder-app-canvas')?.[0];`
`25`		`- const canvasWidth = canvasContainer?.clientWidth \|\| canvas?.clientWidth;`
	`25`	`+ const canvasWidth = useMemo(() => {`
	`26`	`+ return canvasContainer?.clientWidth \|\| canvas?.clientWidth;`
	`27`	`+ }, [canvasContainer?.clientWidth, canvas?.clientWidth]);`
`26`	`28`
`27`	`29`	`const getDeviceType = (width: number) => {`
`28`	`30`	`if (width < 768) return ScreenTypes.Mobile;`
`@@ -71,7 +73,9 @@ export function useScreenInfo() {`
`71`	`73`	`}, [ updateScreenInfo ])`
`72`	`74`
`73`	`75`	`useEffect(() => {`
`74`		`- updateScreenInfo();`
	`76`	`+ if (canvasWidth) {`
	`77`	`+ updateScreenInfo();`
	`78`	`+ }`
`75`	`79`	`}, [canvasWidth]);`
`76`	`80`
`77`	`81`	`return screenInfo;`

Lines changed: 9 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,12 +64,15 @@ let ThemeTempComp = withViewFn(`
`64`	`64`	`return stateValue;`
`65`	`65`	`}, [themeList, currentTheme, stateValue])`
`66`	`66`
`67`		`- if (!isEqual(themeValue, stateValue)) {`
`68`		`- comp.children.stateValue.dispatchChangeValueAction({`
`69`		`- ...exposingTheme(currentTheme),`
`70`		`- allThemes: themeList.map((t) => exposingTheme(t)),`
`71`		`- })`
`72`		`- }`
	`67`	`+ useEffect(() => {`
	`68`	`+ if (!isEqual(themeValue, stateValue)) {`
	`69`	`+ comp.children.stateValue.dispatchChangeValueAction({`
	`70`	`+ ...exposingTheme(currentTheme),`
	`71`	`+ allThemes: themeList.map((t) => exposingTheme(t)),`
	`72`	`+ })`
	`73`	`+ }`
	`74`	`+ }, [themeValue, stateValue]);`
	`75`	`+`
`73`	`76`	`return null;`
`74`	`77`	`}`
`75`	`78`	`);`

Comments

(0)