Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

identify: specify how to handle invalid public keys #651

Open
@jameshiew

Description

If a remote peer provides a public key in an identify message that doesn't match their peer ID, it's not specified how it should be handled.

Potentially the connection could be closed since this shouldn't happen unless the remote peer is misconfigured/malicious (discussion at libp2p/rust-libp2p#5713 / libp2p/rust-libp2p#5707 (comment))

We could add something to the spec (https://github.com/libp2p/specs/tree/master/identify#publickey) like:

If a remote peer provides a public key which doesn't match their peer ID, the receiving node SHOULD close the connection.

So existing implementations which don't do this would still match the v1.0.0 spec.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Triage

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /