Commit cd5d4ef

authored

fix: can not star bug also add test (#49)

1 parent eded574 commit cd5d4efCopy full SHA for cd5d4ef

File tree

4 files changed

+21

-25

lines changed

lib/plugins
- leetcode.js
test
- mock
  - find-the-difference-star.json.20200821
  - find-the-difference-unstar.json.20200821
- plugins
  - test_leetcode.js

4 files changed

+21

-25

lines changed

`‎lib/plugins/leetcode.js`

Lines changed: 14 additions & 20 deletions

Original file line number	Diff line number	Diff line change
`@@ -360,31 +360,25 @@ plugin.getSubmission = function(submission, cb) {`
`360`	`360`
`361`	`361`	`plugin.starProblem = function(problem, starred, cb) {`
`362`	`362`	`log.debug('running leetcode.starProblem');`
`363`		`- const opts = plugin.makeOpts();`
	`363`	`+ const user = session.getUser();`
	`364`	`+ const operationName = starred ? 'addQuestionToFavorite' : 'removeQuestionFromFavorite';`
	`365`	`+ const opts = plugin.makeOpts(config.sys.urls.graphql);`
`364`	`366`	`opts.headers.Origin = config.sys.urls.base;`
`365`	`367`	`opts.headers.Referer = problem.link;`
`366`	`368`
`367`		`- const user = session.getUser();`
`368`		`- if (starred) {`
`369`		`- opts.url = config.sys.urls.favorites;`
`370`		`- opts.method = 'POST';`
`371`		`- opts.json = true;`
`372`		`- opts.body = {`
`373`		`- favorite_id_hash: user.hash,`
`374`		`- question_id: problem.id`
`375`		`- };`
`376`		`- } else {`
`377`		`- opts.url = config.sys.urls.favorite_delete`
`378`		`- .replace('$hash', user.hash)`
`379`		`- .replace('$id', problem.id);`
`380`		`- opts.method = 'DELETE';`
`381`		`- }`
	`369`	`+ opts.json = true;`
	`370`	`+ opts.body = {`
	`371`	+ query: `mutation ${operationName}($favoriteIdHash: String!, $questionId: String!) {\n ${operationName}(favoriteIdHash: $favoriteIdHash, questionId: $questionId) {\n ok\n error\n favoriteIdHash\n questionId\n __typename\n }\n}\n`,
	`372`	`+ variables: {favoriteIdHash: user.hash, questionId: '' + problem.id},`
	`373`	`+ operationName: operationName`
	`374`	`+ };`
`382`	`375`
`383`		`- request(opts, function(e, resp, body) {`
`384`		`- e = plugin.checkError(e, resp, 204);`
	`376`	`+ const spin = h.spin(starred? 'star': 'unstar' + 'problem');`
	`377`	`+ request.post(opts, function(e, resp, body) {`
	`378`	`+ spin.stop();`
	`379`	`+ e = plugin.checkError(e, resp, 200);`
`385`	`380`	`if (e) return cb(e);`
`386`		`-`
`387`		`- cb(null, starred);`
	`381`	`+ return cb(null, starred);`
`388`	`382`	`});`
`389`	`383`	`};`
`390`	`384`

`‎test/mock/find-the-difference-star.json.20200821`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+{"data":{"addQuestionToFavorite":{"ok":true,"error":null,"favoriteIdHash":"","questionId":"389","__typename":"AddQuestionToFavorite"}}}`

`‎test/mock/find-the-difference-unstar.json.20200821`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+{"data":{"removeQuestionFromFavorite":{"ok":true,"error":null,"favoriteIdHash":"","questionId":"389","__typename":"RemoveQuestionFromFavorite"}}}`

`‎test/plugins/test_leetcode.js`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -508,8 +508,8 @@ describe('plugin:leetcode', function() {`
`508`	`508`	`describe('#starProblem', function() {`
`509`	`509`	`it('should star ok', function(done) {`
`510`	`510`	`nock('https://leetcode.com')`
`511`		`- .post('/list/api/questions')`
`512`		`- .reply(204, '');`
	`511`	`+ .post('/graphql')`
	`512`	`+ .replyWithFile(200, './test/mock/find-the-difference-star.json.20200821');`
`513`	`513`
`514`	`514`	`plugin.starProblem(PROBLEM, true, function(e, starred) {`
`515`	`515`	`assert.equal(e, null);`
`@@ -520,8 +520,8 @@ describe('plugin:leetcode', function() {`
`520`	`520`
`521`	`521`	`it('should unstar ok', function(done) {`
`522`	`522`	`nock('https://leetcode.com')`
`523`		`- .delete('/list/api/questions/abcdef/389')`
`524`		`- .reply(204, '');`
	`523`	`+ .post('/graphql')`
	`524`	`+ .replyWithFile(200, './test/mock/find-the-difference-unstar.json.20200821');`
`525`	`525`
`526`	`526`	`plugin.starProblem(PROBLEM, false, function(e, starred) {`
`527`	`527`	`assert.equal(e, null);`
`@@ -532,7 +532,7 @@ describe('plugin:leetcode', function() {`
`532`	`532`
`533`	`533`	`it('should star fail if http error', function(done) {`
`534`	`534`	`nock('https://leetcode.com')`
`535`		`- .post('/list/api/questions')`
	`535`	`+ .post('/graphql')`
`536`	`536`	`.replyWithError('unknown error!');`
`537`	`537`
`538`	`538`	`plugin.starProblem(PROBLEM, true, function(e, starred) {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit cd5d4ef

File tree

4 files changed

4 files changed

`‎lib/plugins/leetcode.js`

`‎test/mock/find-the-difference-star.json.20200821`

`‎test/mock/find-the-difference-unstar.json.20200821`

`‎test/plugins/test_leetcode.js`

0 commit comments