Commit f8bd4fd

committed

fix(linked-list): insert in the middle bug

When inserting an item on the middle of a linked list one reference was not being updated properly. Fixed amejiarosario#8

1 parent 9284acb commit f8bd4fdCopy full SHA for f8bd4fd

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ class LinkedList {`
`96`	`96`	`newNode.next = current; // <5>`
`97`	`97`
`98`	`98`	`current.previous.next = newNode; // <6>`
`99`		`- if(current.next){current.next.previous = newNode;} // <7>`
	`99`	`+ current.previous = newNode; // <7>`
`100`	`100`	`this.size += 1;`
`101`	`101`	`return newNode;`
`102`	`102`	`}`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -165,8 +165,12 @@ describe('LinkedList Test', () => {`
`165`	`165`	`it('should insert at the middle', () => {`
`166`	`166`	`const newNode = linkedList.add('middle', 1);`
`167`	`167`	`expect(newNode.value).toBe('middle');`
	`168`	`+ // checking the 4 surrounding links were updated`
`168`	`169`	`expect(newNode.next.value).toBe('found');`
`169`	`170`	`expect(newNode.previous.value).toBe(0);`
	`171`	`+ expect(linkedList.get(0).next.value).toBe('middle');`
	`172`	`+ expect(linkedList.get(2).previous.value).toBe('middle');`
	`173`	`+`
`170`	`174`	`expect(linkedList.size).toBe(3);`
`171`	`175`	`expect(linkedList.first.value).toBe(0);`
`172`	`176`	`});`

Comments

(0)