This repository was archived by the owner on Jun 5, 2024. It is now read-only.

Commit 5d7b6a6

authored

corrected string comparison, always use quotes

#24 https://unix.stackexchange.com/questions/131766/why-does-my-shell-script-choke-on-whitespace-or-other-special-characters the linked issue failure corner case was when the output of command contained glob characters, for ex: `a[2]` if string is unquoted on RHS of comparison operator, it is treated as glob comparison, not string comparison hence why quotes are needed here

1 parent d082d4e commit 5d7b6a6Copy full SHA for 5d7b6a6

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ while IFS= read -u3 -r ref_line && read -u4 -r sol_line; do`
`43`	`43`	`sub_sol=0`
`44`	`44`	`fi`
`45`	`45`
`46`		`- if [[ $(eval "command ${ref_line:10}") == $(eval "command $sol_line") ]]; then`
	`46`	`+ if [[ "$(eval "command ${ref_line:10}")" == "$(eval "command $sol_line")" ]]; then`
`47`	`47`	`(( sol_count++ ))`
`48`	`48`	`# use color if terminal supports`
`49`	`49`	`echo '---------------------------------------------'`

Comments

(0)