Commit d34d857

authored

update newCollection override to account for automatic eager loading (#10737)

due to the new "automatic eager loading" feature, and the changes made here: laravel/framework@5548f95 the programmer needs to also include these changes when using the `newCollection()` method override for a custom collection, if they want the automatic eager loading feature to work correctly.

1 parent 48dac93 commit d34d857Copy full SHA for d34d857

File tree

1 file changed

-1

lines changed

eloquent-collections.md

1 file changed

-1

lines changed

`‎eloquent-collections.md‎`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,13 @@ class User extends Model`
`335`	`335`	`*/`
`336`	`336`	`public function newCollection(array $models = []): Collection`
`337`	`337`	`{`
`338`		`- return new UserCollection($models);`
	`338`	`+ $collection = new UserCollection($models);`
	`339`	`+`
	`340`	`+ if (Model::isAutomaticallyEagerLoadingRelationships()) {`
	`341`	`+ $collection->withRelationshipAutoloading();`
	`342`	`+ }`
	`343`	`+`
	`344`	`+ return $collection;`
`339`	`345`	`}`
`340`	`346`	`}`
`341`	`347`	```

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit d34d857

File tree

1 file changed

1 file changed

`‎eloquent-collections.md‎`

0 commit comments