Commit 9840f5e

committed

--fix : eslint & code coverage 100%

1 parent b7ec098 commit 9840f5eCopy full SHA for 9840f5e

File tree

+14

-11

lines changed

src/_DataStructures_/Trees/BinarySearchTree/lowest-common-ancestor
- index.js
- index.test.js

+14

-11

lines changed

Lines changed: 4 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,18 +3,15 @@`
`3`	`3`	`*`
`4`	`4`	`* Given values of two values n1 and n2 in a Binary Search Tree, find the Lowest Common Ancestor (LCA). You may assume that both the values exist in the tree.`
`5`	`5`	`*/`
`6`		`-`
	`6`	`+`
`7`	`7`	`function lca(node, n1, n2) {`
`8`		`- if (node == null)`
`9`		`- return null;`
	`8`	`+ if (node == null) return null;`
`10`	`9`
`11`	`10`	`// If both n1 and n2 are smaller than root, then LCA lies in left`
`12`		`- if (node.value > n1 && node.value > n2)`
`13`		`- return lca(node.leftChild, n1, n2);`
	`11`	`+ if (node.value > n1 && node.value > n2) { return lca(node.leftChild, n1, n2); }`
`14`	`12`
`15`	`13`	`// If both n1 and n2 are greater than root, then LCA lies in right`
`16`		`- if (node.value < n1 && node.value < n2)`
`17`		`- return lca(node.rightChild, n1, n2);`
	`14`	`+ if (node.value < n1 && node.value < n2) { return lca(node.rightChild, n1, n2); }`
`18`	`15`
`19`	`16`	`return node;`
`20`	`17`	`}`

Lines changed: 10 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,8 +5,7 @@ const BinarySearchTree = require('../index');`
`5`	`5`	`// {"left":{"left":{"data":4},"right":{"left":{"data":10},"right":{"data":14},"data":12},"data":8},"right":{"data":22},"data":20}`
`6`	`6`
`7`	`7`	`describe('LCA', () => {`
`8`		`-`
`9`		`- let bst = new BinarySearchTree(20);`
	`8`	`+ const bst = new BinarySearchTree(20);`
`10`	`9`	`bst.add(22);`
`11`	`10`	`bst.add(8);`
`12`	`11`	`bst.add(12);`
`@@ -17,12 +16,19 @@ describe('LCA', () => {`
`17`	`16`	`it('Should return 12', () => {`
`18`	`17`	`expect(lca(bst.root, 10, 14).value).toEqual(12);`
`19`	`18`	`});`
`20`		`-`
	`19`	`+`
`21`	`20`	`it('Should return 8', () => {`
`22`	`21`	`expect(lca(bst.root, 14, 8).value).toEqual(8);`
`23`	`22`	`});`
`24`		`-`
	`23`	`+`
`25`	`24`	`it('Should return 20', () => {`
`26`	`25`	`expect(lca(bst.root, 10, 22).value).toEqual(20);`
`27`	`26`	`});`
	`27`	`+`
	`28`	`+ const bst2 = new BinarySearchTree(6);`
	`29`	`+ bst2.remove(6);`
	`30`	`+`
	`31`	`+ it('Should return Null', () => {`
	`32`	`+ expect(lca(bst2.root, 10, 22)).toEqual(null);`
	`33`	`+ });`
`28`	`34`	`});`

Comments

(0)