Skip to content

Commit be185ac

authored

Fix infinity loop with negative numbers (trekhleb#502)

* Update countSetBits.js * Update countSetBits.test.js

1 parent 5a3806f commit be185acCopy full SHA for be185ac

File tree

2 files changed

+5

-1

lines changed

src/algorithms/math/bits
- __test__
  - countSetBits.test.js
- countSetBits.js

2 files changed

+5

-1

lines changed

`‎src/algorithms/math/bits/test/countSetBits.test.js‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,5 +11,9 @@ describe('countSetBits', () => {`
`11`	`11`	`expect(countSetBits(21)).toBe(3);`
`12`	`12`	`expect(countSetBits(255)).toBe(8);`
`13`	`13`	`expect(countSetBits(1023)).toBe(10);`
	`14`	`+ expect(countSetBits(-1)).toBe(32);`
	`15`	`+ expect(countSetBits(-21)).toBe(30);`
	`16`	`+ expect(countSetBits(-255)).toBe(25);`
	`17`	`+ expect(countSetBits(-1023)).toBe(23);`
`14`	`18`	`});`
`15`	`19`	`});`

`‎src/algorithms/math/bits/countSetBits.js‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ export default function countSetBits(originalNumber) {`
`11`	`11`	`setBitsCount += number & 1;`
`12`	`12`
`13`	`13`	`// Shift number right by one bit to investigate other bits.`
`14`		`- number >>= 1;`
	`14`	`+ number >>>= 1;`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`return setBitsCount;`

0 commit comments

Comments

(0)