Commit fa1840c

authored

Merge pull request bugsnag#794 from bugsnag/v7-enabled-breadcrumbs

fix: Ensure breadcrumbs behave correctly

2 parents 7a62ec4 + ffb6afa commit fa1840cCopy full SHA for fa1840c

File tree

+25

-6

lines changed

+25

-6

lines changed

Lines changed: 8 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -301,12 +301,14 @@ class Client {`
`301`	`301`	`return cb(null, event)`
`302`	`302`	`}`
`303`	`303`
`304`		`- // only leave a crumb for the error if actually got sent`
`305`		`- Client.prototype.leaveBreadcrumb.call(this, event.errors[0].errorClass, {`
`306`		`- errorClass: event.errors[0].errorClass,`
`307`		`- errorMessage: event.errors[0].errorMessage,`
`308`		`- severity: event.severity`
`309`		`- }, 'error')`
	`304`	`+ if (includes(this._config.enabledBreadcrumbTypes, 'error')) {`
	`305`	`+ // only leave a crumb for the error if actually got sent`
	`306`	`+ Client.prototype.leaveBreadcrumb.call(this, event.errors[0].errorClass, {`
	`307`	`+ errorClass: event.errors[0].errorClass,`
	`308`	`+ errorMessage: event.errors[0].errorMessage,`
	`309`	`+ severity: event.severity`
	`310`	`+ }, 'error')`
	`311`	`+ }`
`310`	`312`
`311`	`313`	`if (originalSeverity !== event.severity) {`
`312`	`314`	`event._handledState.severityReason = { type: 'userCallbackSetSeverity' }`

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -487,6 +487,21 @@ describe('@bugsnag/core/client', () => {`
`487`	`487`	`expect(client._breadcrumbs.length).toBe(1)`
`488`	`488`	`expect(client._breadcrumbs[0].type).toBe('manual')`
`489`	`489`	`})`
	`490`	`+`
	`491`	`+ it('only leaves an error breadcrumb if enabledBreadcrumbTypes contains "error"', (done) => {`
	`492`	`+ const client = new Client({`
	`493`	`+ apiKey: 'API_KEY_YEAH',`
	`494`	`+ enabledBreadcrumbTypes: []`
	`495`	`+ })`
	`496`	`+ client._setDelivery(client => ({`
	`497`	`+ sendSession: () => {},`
	`498`	`+ sendEvent: (payload, cb) => cb(null)`
	`499`	`+ }))`
	`500`	`+ client.notify(new Error('oh no'), () => {}, () => {`
	`501`	`+ expect(client._breadcrumbs.length).toBe(0)`
	`502`	`+ done()`
	`503`	`+ })`
	`504`	`+ })`
`490`	`505`	`})`
`491`	`506`
`492`	`507`	`describe('startSession()', () => {`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,8 @@ const Bugsnag = {`
`54`	`54`	`bugsnag._logger.warn('Breadcrumbs are not supported in Node.js yet')`
`55`	`55`	`}`
`56`	`56`
	`57`	`+ bugsnag._config.enabledBreadcrumbTypes = []`
	`58`	`+`
`57`	`59`	`return bugsnag`
`58`	`60`	`},`
`59`	`61`	`start: (opts) => {`

Comments

(0)