Commit ecdad1b

jrfnlvillfa

and

committed

GH Actions: fix failing tests on PHP 5.3-5.5

I still can't fathom why the tests were previously passing and are failing now. I know they were running fine before as I checked the logs on multiple occasions. I've now [unearthed the documentation from Nette Tester 1.x](https://web.archive.org/web/20170602082733/https://tester.nette.org/#toc-how-the-tester-runs) which what's used to run the tests on PHP 5.3-5.5. The docs state: > The Tester runs PHP processes with `-n` option, so without `php.ini`. More details in the [Own php.ini chapter](https://web.archive.org/web/20170602082733/https://tester.nette.org/#toc-own-php-ini). ... which in a way is similar to the problem we previously ran into for Nette Tester 2.x, which is why the `-C` (= Use system-wide `php.ini`) option is used there. Also see php-parallel-lint/PHP-Parallel-Lint#55 As the tests were running and passing on Nette 1.x/PHP 5.3 - 5.5 previously, we never dug in deeper for the peculiarities of Nette 1.x. So to fix the test runs against PHP 5.3 - 5.5, which are using Nette Tester 1.x, I'm proposing to add a `php.ini` file to the `tests` directory specifically for use with PHP 5.3 - 5.5. This should get the tests passing again. I'm adding villfa as co-author to this PR as I ended up with this solution inspired by [a PR they pulled to my fork of this repo](#1). Co-authored-by: Fabien Villepinte <fabien.villepinte@gmail.com>

1 parent 02a09f1 commit ecdad1bCopy full SHA for ecdad1b

File tree

2 files changed

+11

-1

lines changed

composer.json
tests
- php5.3-5.5.ini

2 files changed

+11

-1

lines changed

`‎composer.json‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@`
`38`	`38`	`],`
`39`	`39`	`"scripts": {`
`40`	`40`	`"test": "@php vendor/bin/tester -C -p php tests",`
`41`		`- "testphp5": "@php vendor/bin/tester -p php tests"`
	`41`	`+ "testphp5": "@php vendor/bin/tester -c tests/php5.3-5.5.ini -p php tests"`
`42`	`42`	`},`
`43`	`43`	`"scripts-descriptions": {`
`44`	`44`	`"test": "Run all tests!"`

`‎tests/php5.3-5.5.ini‎`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,10 @@`
	`1`	`+[PHP]`
	`2`	`+`
	`3`	`+extension=json.so`
	`4`	`+extension=tokenizer.so`
	`5`	`+`
	`6`	`+memory_limit=512M`
	`7`	`+`
	`8`	`+error_reporting=-1`
	`9`	`+display_errors=On`
	`10`	`+display_startup_errors = On`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit ecdad1b

File tree

2 files changed

2 files changed

`‎composer.json‎`

`‎tests/php5.3-5.5.ini‎`

0 commit comments