Commit 6410140

authored

Fix check for an empty input or ESC key press

According to the task both of these should give an alert('Canceled'). Previous solution implied that both empty input and ESC key return null, but in Chrome 64.0.3282.186 an empty input returns '' instead of null. So we are adding an additional check.

1 parent 9365275 commit 6410140Copy full SHA for 6410140

File tree

1 file changed

-2

lines changed

1-js/02-first-steps/10-ifelse/4-check-login
- solution.md

1 file changed

-2

lines changed

`‎1-js/02-first-steps/10-ifelse/4-check-login/solution.md‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,13 +9,13 @@ if (userName == 'Admin') {`
`9`	`9`
`10`	`10`	`if (pass == 'TheMaster') {`
`11`	`11`	`alert( 'Welcome!' );`
`12`		`- } else if (pass == null) {`
	`12`	`+ } else if (pass == ''\|\| pass ==null) {`
`13`	`13`	`alert( 'Canceled.' );`
`14`	`14`	`} else {`
`15`	`15`	`alert( 'Wrong password' );`
`16`	`16`	`}`
`17`	`17`
`18`		`-} else if (userName == null) {`
	`18`	`+} else if (userName == ''\|\| userName ==null) {`
`19`	`19`	`alert( 'Canceled' );`
`20`	`20`	`} else {`
`21`	`21`	`alert( "I don't know you" );`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 6410140

File tree

1 file changed

1 file changed

`‎1-js/02-first-steps/10-ifelse/4-check-login/solution.md‎`

0 commit comments