Commit 0395673

authored

Safari does not return an empty string when a prompt is cancelled

title

1 parent 3b25bc5 commit 0395673Copy full SHA for 0395673

File tree

-9

lines changed

-9

lines changed

Lines changed: 3 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,23 +9,17 @@ if (userName == 'Admin') {`
`9`	`9`
`10`	`10`	`if (pass == 'TheMaster') {`
`11`	`11`	`alert( 'Welcome!' );`
`12`		`- } else if (pass == null\|\| pass =='') {// (*)`
	`12`	`+ } else if (pass == null) {`
`13`	`13`	`alert( 'Canceled.' );`
`14`	`14`	`} else {`
`15`	`15`	`alert( 'Wrong password' );`
`16`	`16`	`}`
`17`	`17`
`18`		`-} else if (userName == null \|\| userName == '') { // (**)`
`19`		`-`
	`18`	`+} else if (userName == null) {`
`20`	`19`	`alert( 'Canceled' );`
`21`		`-`
`22`	`20`	`} else {`
`23`		`-`
`24`	`21`	`alert( "I don't know you" );`
`25`		`-`
`26`	`22`	`}`
`27`	`23`	```
`28`	`24`
`29`		-Please note the `if` check in lines `()` and `(*)`. Every browser except Safari returns `null` when the input is canceled, and Safari returns an empty string. So we must treat them same for compatibility.
`30`		`-`
`31`		-Also note the vertical indents inside the `if` blocks. They are technically not required, but make the code more readable.
	`25`	+Note the vertical indents inside the `if` blocks. They are technically not required, but make the code more readable.

Comments

(0)