Commit 207fe5b

committed

Clearer messages for when denied test fails

Signed-off-by: arjantijms <arjan.tijms@gmail.com>

1 parent 8bdef70 commit 207fe5bCopy full SHA for 207fe5b

File tree

-2

lines changed

servlet/security-deny-uncovered/src/test/java/org/javaee7/servlet/security/deny/uncovered
- SecureServletTest.java

-2

lines changed

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`	`import static org.javaee7.ServerOperations.addUsersToContainerIdentityStore;`
`6`	`6`	`import static org.jboss.shrinkwrap.api.ShrinkWrap.create;`
`7`	`7`	`import static org.junit.Assert.assertEquals;`
	`8`	`+import static org.junit.Assert.assertFalse;`
`8`	`9`	`import static org.junit.Assert.assertNotNull;`
`9`	`10`	`import static org.junit.Assert.fail;`
`10`	`11`
`@@ -78,16 +79,21 @@ public void testPostMethod() throws Exception {`
`78`	`79`	`webClient.setCredentialsProvider(correctCreds);`
`79`	`80`	`WebRequest request = new WebRequest(new URL(base + "SecureServlet"), POST);`
`80`	`81`
	`82`	`+ TextPage p = null;`
`81`	`83`	`try {`
`82`		`- TextPagep = webClient.getPage(request);`
	`84`	`+ p = webClient.getPage(request);`
`83`	`85`	`System.out.println(p.getContent());`
	`86`	`+`
	`87`	`+ assertFalse(`
	`88`	`+ "POST method could be called even with deny-uncovered-http-methods",`
	`89`	`+ p.getContent().contains("my POST"));`
`84`	`90`	`} catch (FailingHttpStatusCodeException e) {`
`85`	`91`	`assertNotNull(e);`
`86`	`92`	`assertEquals(403, e.getStatusCode());`
`87`	`93`	`return;`
`88`	`94`	`}`
`89`	`95`
`90`		`- fail("POST method could be called even with deny-uncovered-http-methods");`
	`96`	`+ fail("POST correctly not called, but wrong status code: " + (p != null ? p.getWebResponse().getStatusCode() : -1));`
`91`	`97`	`}`
`92`	`98`
`93`	`99`	`@Test`

Comments

(0)