Commit 897885b

authored

Fixed sonar warning.

1 parent 6dd3ade commit 897885bCopy full SHA for 897885b

File tree

-7

lines changed

src/main/java/g0301_0400
- s0367_valid_perfect_square
  - Solution.java
- s0368_largest_divisible_subset
  - Solution.java

-7

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ public boolean isPerfectSquare(int num) {`
`13`	`13`	`long end = num;`
`14`	`14`	`long mid = 0;`
`15`	`15`	`while (start <= end) {`
`16`		`- // untill start is lesser or equal to end do this`
	`16`	`+ // until start is lesser or equal to end do this`
`17`	`17`	`// Finding middle value`
`18`	`18`	`mid = start + (end - start) / 2;`
`19`	`19`	`if (mid * mid == num) {`

Lines changed: 4 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`
`9`	`9`	`public class Solution {`
`10`	`10`	`// Helper class containing value and an arraylist`
`11`		`- public class Helper {`
	`11`	`+ private class Helper {`
`12`	`12`	`int val;`
`13`	`13`	`List<Integer> al;`
`14`	`14`
`@@ -34,11 +34,9 @@ public List<Integer> largestDivisibleSubset(int[] nums) {`
`34`	`34`	`int max2 = 0;`
`35`	`35`	`int pos = i;`
`36`	`36`	`for (int j = 0; j < i; j++) {`
`37`		`- if (nums[i] % nums[j] == 0) {`
`38`		`- if (max2 < dp[j].val) {`
`39`		`- max2 = dp[j].val;`
`40`		`- pos = j;`
`41`		`- }`
	`37`	`+ if (nums[i] % nums[j] == 0 && max2 < dp[j].val) {`
	`38`	`+ max2 = dp[j].val;`
	`39`	`+ pos = j;`
`42`	`40`	`}`
`43`	`41`	`}`
`44`	`42`	`// max2 = 0, means no element exists which can divide the present element`

Comments

(0)