Commit c056a84

authored

Remove warning about unknown graphql.server.all_resolvers (DataDog#6344)

1 parent 425c4cc commit c056a84Copy full SHA for c056a84

File tree

-1

lines changed

dd-java-agent/appsec/src
- main/java/com/datadog/appsec/event/data
  - KnownAddresses.java
- test/groovy/com/datadog/appsec/event/data
  - KnownAddressesSpecification.groovy

-1

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,9 @@ public interface KnownAddresses {`
`98`	`98`	`// XXX: Not really used yet, but it's a known address and we should not treat it as unknown.`
`99`	`99`	`Address<Object> GRPC_SERVER_REQUEST_METADATA = new Address<>("grpc.server.request.metadata");`
`100`	`100`
	`101`	`+ // XXX: Not really used yet, but it's a known address and we should not treat it as unknown.`
	`102`	`+ Address<Object> GRAPHQL_SERVER_ALL_RESOLVERS = new Address<>("graphql.server.all_resolvers");`
	`103`	`+`
`101`	`104`	`Address<String> USER_ID = new Address<>("usr.id");`
`102`	`105`
`103`	`106`	`Address<Map<String, Object>> WAF_CONTEXT_PROCESSOR = new Address<>("waf.context.processor");`
`@@ -148,6 +151,8 @@ static Address<?> forName(String name) {`
`148`	`151`	`return GRPC_SERVER_REQUEST_MESSAGE;`
`149`	`152`	`case "grpc.server.request.metadata":`
`150`	`153`	`return GRPC_SERVER_REQUEST_METADATA;`
	`154`	`+ case "graphql.server.all_resolvers":`
	`155`	`+ return GRAPHQL_SERVER_ALL_RESOLVERS;`
`151`	`156`	`case "usr.id":`
`152`	`157`	`return USER_ID;`
`153`	`158`	`case "waf.context.processor":`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -30,14 +30,15 @@ class KnownAddressesSpecification extends Specification {`
`30`	`30`	`'server.request.headers.no_cookies',`
`31`	`31`	`'grpc.server.request.message',`
`32`	`32`	`'grpc.server.request.metadata',`
	`33`	`+ 'graphql.server.all_resolvers',`
`33`	`34`	`'usr.id',`
`34`	`35`	`'waf.context.processor',`
`35`	`36`	`]`
`36`	`37`	`}`
`37`	`38`
`38`	`39`	`void 'number of known addresses is expected number'() {`
`39`	`40`	`expect:`
`40`		`- Address.instanceCount() == 24`
	`41`	`+ Address.instanceCount() == 25`
`41`	`42`	`KnownAddresses.WAF_CONTEXT_PROCESSOR.serial == Address.instanceCount() - 1`
`42`	`43`	`}`
`43`	`44`	`}`

Comments

(0)