Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 00ed376

Browse files
committed
Implement mvn to run tests
mvn implementation used from sample - https://github.com/junit-team/junit5-samples/blob/main/junit5-jupiter-starter-maven/pom.xml Add dependency for parameterized test Solve Hackerrank problem - https://www.hackerrank.com/challenges/java-string-compare 
1 parent 09ecbc9 commit 00ed376

File tree

33 files changed

+175
-157
lines changed

33 files changed

+175
-157
lines changed

‎pom.xml

Lines changed: 27 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -1,104 +1,61 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<project xmlns="http://maven.apache.org/POM/4.0.0"
3-
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
2+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
43
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
54
<modelVersion>4.0.0</modelVersion>
65

7-
<groupId>org.example</groupId>
8-
<artifactId>codechallenge-java-pom</artifactId>
6+
<groupId>com.example</groupId>
7+
<artifactId>junit5-jupiter-starter-maven</artifactId>
98
<version>1.0-SNAPSHOT</version>
109

1110
<properties>
12-
<maven.compiler.source>11</maven.compiler.source>
13-
<maven.compiler.target>11</maven.compiler.target>
1411
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
12+
<maven.compiler.source>1.8</maven.compiler.source>
13+
<maven.compiler.target>${maven.compiler.source}</maven.compiler.target>
1514
</properties>
1615

16+
<dependencyManagement>
17+
<dependencies>
18+
<dependency>
19+
<groupId>org.junit</groupId>
20+
<artifactId>junit-bom</artifactId>
21+
<version>5.9.1</version>
22+
<type>pom</type>
23+
<scope>import</scope>
24+
</dependency>
25+
</dependencies>
26+
</dependencyManagement>
27+
1728
<dependencies>
18-
<dependency>
19-
<groupId>org.junit.platform</groupId>
20-
<artifactId>junit-platform-runner</artifactId>
21-
<version>1.9.0</version>
22-
<scope>test</scope>
23-
</dependency>
2429
<dependency>
2530
<groupId>org.junit.jupiter</groupId>
26-
<artifactId>junit-jupiter-api</artifactId>
27-
<version>5.9.0</version>
31+
<artifactId>junit-jupiter</artifactId>
2832
<scope>test</scope>
2933
</dependency>
3034
<dependency>
3135
<groupId>org.junit.jupiter</groupId>
3236
<artifactId>junit-jupiter-params</artifactId>
33-
<version>5.9.0</version>
37+
<version>5.9.1</version>
3438
<scope>test</scope>
3539
</dependency>
36-
<dependency>
37-
<groupId>org.junit.jupiter</groupId>
38-
<artifactId>junit-jupiter-engine</artifactId>
39-
<version>5.9.0</version>
40-
<scope>test</scope>
41-
</dependency>
42-
<dependency>
43-
<groupId>org.junit.jupiter</groupId>
44-
<artifactId>junit-jupiter-api</artifactId>
45-
<version>5.9.0</version>
46-
<scope>compile</scope>
47-
</dependency>
4840
</dependencies>
4941

5042
<build>
51-
<sourceDirectory>src</sourceDirectory>
5243
<plugins>
5344
<plugin>
54-
<groupId>org.codehaus.mojo</groupId>
55-
<artifactId>exec-maven-plugin</artifactId>
56-
<version>3.0.0</version>
57-
<configuration>
58-
<mainClass>main.java.com.oystercard.CLI</mainClass>
59-
</configuration>
45+
<artifactId>maven-compiler-plugin</artifactId>
46+
<version>3.8.1</version>
6047
</plugin>
6148
<plugin>
62-
<groupId>org.apache.maven.plugins</groupId>
63-
<artifactId>maven-pmd-plugin</artifactId>
64-
<version>3.16.0</version>
65-
<configuration>
66-
<rulesets>
67-
<ruleset>/rulesets/java/braces.xml</ruleset>
68-
<ruleset>/rulesets/java/naming.xml</ruleset>
69-
</rulesets>
70-
</configuration>
71-
</plugin>
72-
73-
<plugin>
74-
<groupId>org.apache.maven.plugins</groupId>
7549
<artifactId>maven-surefire-plugin</artifactId>
76-
<version>2.22.0</version>
77-
<dependencies>
78-
<dependency>
79-
<groupId>org.junit.platform</groupId>
80-
<artifactId>junit-platform-surefire-provider</artifactId>
81-
<version>1.2.0</version>
82-
</dependency>
83-
</dependencies>
50+
<version>3.0.0-M6</version>
8451
</plugin>
8552
<plugin>
8653
<groupId>org.apache.maven.plugins</groupId>
87-
<artifactId>maven-failsafe-plugin</artifactId>
88-
<version>2.6</version>
89-
<executions>
90-
<execution>
91-
<id>integration-test</id>
92-
<goals>
93-
<goal>integration-test</goal>
94-
</goals>
95-
</execution>
96-
<!-- Uncomment/comment this in order to fail the build if any integration test fail -->
97-
<execution>
98-
<id>verify</id>
99-
<goals><goal>verify</goal></goals>
100-
</execution>
101-
</executions>
54+
<artifactId>maven-compiler-plugin</artifactId>
55+
<configuration>
56+
<source>11</source>
57+
<target>11</target>
58+
</configuration>
10259
</plugin>
10360
</plugins>
10461
</build>

‎src/main/java/codesignal/tournaments/CommonPoints/CommonPoints.java renamed to ‎src/main/java/codesignal/tournaments/CommonPointsTest/CommonPoints.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package codesignal.tournaments.CommonPoints;
1+
package codesignal.tournaments.CommonPointsTest;
22

33
public class CommonPoints {
44
public int commonPoints(int l1, int r1, int l2, int r2) {

‎src/main/java/codility/fibobacci/ladder/Solution.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import java.lang.Math;
44

5-
class Solution {
5+
publicclass Solution {
66
public static int[] solution(int[] A, int[] B) {
77
int[] fib = new int[A.length];
88
int a = 0;

‎src/main/java/google/Level2/Part1/Solution.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import java.util.Arrays;
55

6-
class Solution {
6+
publicclass Solution {
77

88
/**
99
* solution Build largest number that can be made from
@@ -12,7 +12,7 @@ class Solution {
1212
* @param arr int[]
1313
* @return int
1414
*/
15-
static int solution(int arr[]) {
15+
publicstatic int solution(int arr[]) {
1616
Arrays.sort(arr);
1717

1818
int sum = getSum(arr);
@@ -47,7 +47,7 @@ static int getSum(int[] arr) {
4747
* @param skipSecond Skip index of array arr
4848
* @return int Largest number divisible by 3.
4949
*/
50-
static int buildNum(int arr[], int skipFirst, int skipSecond) {
50+
publicstatic int buildNum(int arr[], int skipFirst, int skipSecond) {
5151
StringBuilder strBuilder = new StringBuilder();
5252

5353
for (int i = arr.length - 1; i >= 0; i--) {

‎src/main/java/google/Level2/Part1/Thirdparty.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// array and is divisible by 3
77
//https://www.geeksforgeeks.org/find-largest-multiple-3-array-digits-set-2-time-o1-space/
88

9-
class Thirdparty
9+
publicclass Thirdparty
1010
{
1111
// // Number of digits
1212
// static int MAX_SIZE = 10;
@@ -63,7 +63,7 @@ static int getSum(int[] arr) {
6363
return sum;
6464
}
6565

66-
static int solution( int arr[] ) {
66+
publicstatic int solution( int arr[] ) {
6767
int n = arr.length;
6868
Arrays.sort(arr);
6969

‎src/main/java/hackerrank/String/MyRegexMain.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,4 +76,5 @@ public List<String> readLines(){
7676
public List<String> getTestLines(){
7777
return List.of("11331.111.144411.111", "asdafasd.asdasd.dasd..", "001.0.01.1", "255.255.255.255");
7878
}
79+
7980
}

‎src/main/java/hackerrank/ThirtyDaysOfCode/DayTwo.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
package hackerrank.ThirtyDaysOfCode;
22

3-
import java.io.*;
43
import java.util.*;
5-
import java.text.*;
6-
import java.math.*;
7-
import java.util.regex.*;
84

95
/**
106
* Problem:

‎src/main/java/hackerrank/ThirtyDaysOfCode/TwentyNine.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public static void main(String[] args) throws IOException {
1818

1919
int lim = Integer.parseInt(firstMultipleInput[1]);
2020

21-
int res = Result.bitwiseAnd(count, lim);
21+
int res = bitwiseAnd(count, lim);
2222

2323
bufferedWriter.write(String.valueOf(res));
2424
bufferedWriter.newLine();
@@ -30,9 +30,6 @@ public static void main(String[] args) throws IOException {
3030
bufferedReader.close();
3131
bufferedWriter.close();
3232
}
33-
}
34-
35-
class Result {
3633

3734
/*
3835
* Complete the 'bitwiseAnd' function below.

‎src/main/java/leetcode/datastructure/duplicate/two/Solution.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import java.util.stream.IntStream;
66
import static java.lang.Math.abs;
77

8-
class Solution {
8+
publicclass Solution {
99
public boolean containsNearbyDuplicate(int[] nums, int k) {
1010
int[] numsClone = nums.clone();
1111
Arrays.sort(numsClone);

‎src/main/java/talabat/pairprogramming/Solution.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import java.util.HashMap;
44

5-
class Solution {
5+
publicclass Solution {
66
int x, y;
77
char direction;
88

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /