Commit 76badc5

committed

added validation

1 parent 470fc84 commit 76badc5Copy full SHA for 76badc5

File tree

2 files changed

+16

-12

lines changed

index.html
main.js

2 files changed

+16

-12

lines changed

`‎index.html`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,15 +16,15 @@ <h1>javaScript timer App</h1>`
`16`	`16`	`<div id="inputContainer" class="input-items">`
`17`	`17`	`<div class="input-group">`
`18`	`18`	`<label class="input-label">Hour:</label>`
`19`		`- <input onchange="SetTimerValue()" id="inputHour" placeholder="00" class="input-box" type="number">`
	`19`	`+ <input id="inputHour" placeholder="00" class="input-box" type="number">`
`20`	`20`	`</div>`
`21`	`21`	`<div class="input-group">`
`22`	`22`	`<label class="input-label">Minute:</label>`
`23`		`- <input onchange="SetTimerValue()" id="inputMinute" placeholder="00" class="input-box" type="number">`
	`23`	`+ <input id="inputMinute" placeholder="00" min="0" max="59" class="input-box" type="number">`
`24`	`24`	`</div>`
`25`	`25`	`<div class="input-group">`
`26`	`26`	`<label class="input-label">Second:</label>`
`27`		`- <input onchange="SetTimerValue()" id="inputSecond" placeholder="00" class="input-box" type="number">`
	`27`	`+ <input id="inputSecond" placeholder="00" min="0" max="59" class="input-box" type="number">`
`28`	`28`	`</div>`
`29`	`29`	`</div>`
`30`	`30`

`‎main.js`

Lines changed: 13 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,27 +6,31 @@ var outputMinute = document.getElementById("outputMinute");`
`6`	`6`	`var outputSecond = document.getElementById("outputSecond");`
`7`	`7`	`var startBtn = document.getElementById("startBtn");`
`8`	`8`	`var stopBtn = document.getElementById("stopBtn");`
`9`		`-var timer;`
	`9`	`+var timerApp;`
`10`	`10`	`var outputContainer = document.getElementById("outputContainer");`
`11`	`11`
`12`		`-function SetTimerValue()`
	`12`	`+function StartClock()`
`13`	`13`	`{`
`14`	`14`	`inputHour = Number(document.getElementById("inputHour").value);`
`15`	`15`	`inputMinute = Number(document.getElementById("inputMinute").value);`
`16`	`16`	`inputSecond = Number(document.getElementById("inputSecond").value);`
`17`		`-}`
`18`		`-`
`19`		`-function StartClock()`
`20`		`-{`
`21`		`- if(inputHour > 0 \|\| inputMinute > 0 \|\| inputSecond > 0)`
	`17`	`+`
	`18`	`+ if(inputHour > 0 \|\| (inputMinute > 0 && inputMinute < 60)\|\| (inputSecond > 0 && inputSecond < 60))`
`22`	`19`	`{`
`23`	`20`	`outputHour.innerHTML = FormatTime(inputHour);`
`24`	`21`	`outputMinute.innerHTML = FormatTime(inputMinute);`
`25`	`22`	`outputSecond.innerHTML = FormatTime(inputSecond);`
`26`	`23`	`outputContainer.style.display = "flex";`
`27`	`24`	`startBtn.style.display = "none";`
`28`	`25`	`stopBtn.style.display = "inline-block";`
`29`		`- timer = setInterval(myClock, 1000);`
	`26`	`+ timerApp = setInterval(myClock, 1000);`
	`27`	`+ }`
	`28`	`+ else`
	`29`	`+ {`
	`30`	`+ document.getElementById("inputHour").value = "";`
	`31`	`+ document.getElementById("inputMinute").value = "";`
	`32`	`+ document.getElementById("inputSecond").value = "";`
	`33`	`+ alert("Enter valid time.");`
`30`	`34`	`}`
`31`	`35`	`}`
`32`	`36`
`@@ -35,7 +39,7 @@ function StopClock()`
`35`	`39`	`startBtn.style.display = "inline-block";`
`36`	`40`	`stopBtn.style.display = "none";`
`37`	`41`
`38`		`- clearInterval(timer);`
	`42`	`+ clearInterval(timerApp);`
`39`	`43`	`}`
`40`	`44`
`41`	`45`	`function ResetClock()`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 76badc5

File tree

2 files changed

2 files changed

`‎index.html`

`‎main.js`

0 commit comments