Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 140c33f

Browse files
committed
Refactored the code
1 parent 9f67731 commit 140c33f

File tree

13 files changed

+29
-46
lines changed

13 files changed

+29
-46
lines changed

‎app/components/App/AppView.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ import HelpButton from '../HelpButton';
55

66
export default () =>
77
<div className="container">
8-
<Title/>
9-
<HelpButton/>
8+
<Title/>
9+
<HelpButton/>
1010
</div>;

‎app/components/App/AppView.native.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@ import HelpButton from '../HelpButton';
88

99
export default () =>
1010
<View style={styles.container}>
11-
<Title/>
12-
<HelpButton/>
11+
<Title/>
12+
<HelpButton/>
1313
</View>;

‎app/components/App/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,2 @@
1-
import React from 'react';
21
import AppView from './AppView';
3-
4-
export default () => <AppView />;
2+
export default AppView;

‎app/components/HelpButton/AbstractHelpButtonContainer.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@ import HelpButtonView from './HelpButtonView';
33

44
export default class AbstractHelpButtonContainer extends React.Component {
55
constructor(props) {
6-
if (new.target === AbstractHelpButtonContainer) {
7-
throw new TypeError('Cannot construct AbstractHelpButtonContainer instances directly');
8-
}
6+
// new.target is not working on Android
7+
// if (new.target === AbstractHelpButtonContainer) {
8+
// throw new TypeError('Cannot construct AbstractHelpButtonContainer instances directly');
9+
// }
10+
911
super(props);
1012

1113
this.onClick = this.onClick.bind(this);
@@ -16,8 +18,6 @@ export default class AbstractHelpButtonContainer extends React.Component {
1618
}
1719

1820
render() {
19-
return (
20-
<HelpButtonView onClick={this.onClick} />
21-
);
21+
return <HelpButtonView onClick={this.onClick}/>;
2222
}
2323
}
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import React from 'react';
22

33
export default props =>
4-
<button className="help-button" onClick={props.onClick}>Help</button>;
4+
<button className="help-button" onClick={props.onClick}>
5+
Help
6+
</button>;

‎app/components/HelpButton/HelpButtonView.native.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import React from 'react';
2-
import { Alert } from 'react-native';
32
import Button from 'react-native-button';
43

54
import styles from '../../native/styles';

‎app/components/HelpButton/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,2 @@
1-
import React from 'react';
21
import HelpButtonContainer from './HelpButtonContainer';
3-
4-
export default () => <HelpButtonContainer />;
2+
export default HelpButtonContainer;

‎app/components/Title/TitleView.android.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,6 @@ import { Text } from 'react-native';
44
import styles from '../../native/styles';
55

66
export default () =>
7-
<Text style={styles.title}>React Native Code Reuse (Android)</Text>;
7+
<Text style={styles.title}>
8+
React Native Code Reuse (Android)
9+
</Text>;

‎app/components/Title/TitleView.ios.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,6 @@ import { Text } from 'react-native';
44
import styles from '../../native/styles';
55

66
export default () =>
7-
<Text style={styles.title}>React Native Code Reuse (iOS)</Text>;
7+
<Text style={styles.title}>
8+
React Native Code Reuse (iOS)
9+
</Text>;

‎app/components/Title/TitleView.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import React from 'react';
22

33
export default () =>
4-
<h1 className="title">React Native Code Reuse (Web)</h1>;
4+
<h1 className="title">
5+
React Native Code Reuse (Web)
6+
</h1>;

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /