Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit a3d646a

Browse files
hot9cupsignacio-chiazzo
authored andcommitted
Enhancing Tests.js logic
- Modified Tests.js to get rid of hardcoding and work for files having variable number of test methods. Now any number of tests can be exported and can also be named anything(As opposed to being 'test' from earlier)
1 parent b4ac443 commit a3d646a

File tree

2 files changed

+14
-15
lines changed

2 files changed

+14
-15
lines changed

‎LeetcodeProblemsTests/Algorithms/2Sum_Test.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,18 @@ const twoSum = require("../../LeetcodeProblems/Algorithms/2Sum").twoSum;
33
const twoSum2 = require("../../LeetcodeProblems/Algorithms/2Sum").twoSum2;
44

55

6-
var test = function () {
6+
var testFirstSolution = function () {
77
assert.deepEqual([0,1], twoSum([2,7,11,15], 9));
88
assert.deepEqual([1,2], twoSum([3,2,4], 6));
99
assert.deepEqual([0,1], twoSum([3,3], 6));
10-
10+
};
11+
12+
var testSecondSolution = function() {
1113
assert.deepEqual([0,1], twoSum2([2,7,11,15], 9));
1214
assert.deepEqual([1,2], twoSum2([3,2,4], 6));
1315
assert.deepEqual([0,1], twoSum2([3,3], 6));
1416
};
1517

1618

17-
module.exports.test = test;
19+
module.exports.testFirstSolution = testFirstSolution;
20+
module.exports.testSecondSolution = testSecondSolution;

‎Test.js

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,15 @@ var test_all = async function () {
1010
const problems = await loadProblems();
1111
for (i in problems) {
1212
console.log("Solving: " + problems[i]);
13-
const problem = require(TESTS_FOLDER + problems[i]);
14-
15-
if (typeof problem.test !== "undefined") {
16-
problem.test();
17-
console.log("✅ Tests for " + problems[i] + " run successfully \n");
18-
} else {
19-
console.warn(
20-
problem,
21-
"🔴 The problem " +
22-
problems[i] +
23-
" doesn't have a test method implemented.\n"
24-
);
13+
const tests = require(TESTS_FOLDER + problems[i]);
14+
if (Object.keys(tests).length == 0) {
15+
console.warn("🔴 The problem " + problems[i] + " doesn't have a test method implemented.\n");
16+
continue;
17+
}
18+
for(testIdx in tests) {
19+
tests[testIdx]();
2520
}
21+
console.log("✅ Tests for " + problems[i] + " run successfully \n");
2622
}
2723
} catch (error) {
2824
throw new Error(error);

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /