Commit c8b3fb9

authored

Merge pull request trekhleb#3 from PeterShershov/master

small refactor in some sorting algorithms for better readability

2 parents d596e1d + 297875e commit c8b3fb9Copy full SHA for c8b3fb9

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ export default class BubbleSort extends Sort {`
`5`	`5`	`// Flag that holds info about whether the swap has occur or not.`
`6`	`6`	`let swapped = false;`
`7`	`7`	`// Clone original array to prevent its modification.`
`8`		`- const array = originalArray.slice(0);`
	`8`	`+ const array = [...originalArray];`
`9`	`9`
`10`	`10`	`for (let i = 0; i < array.length; i += 1) {`
`11`	`11`	`swapped = false;`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ import Sort from '../Sort';`
`2`	`2`
`3`	`3`	`export default class InsertionSort extends Sort {`
`4`	`4`	`sort(originalArray) {`
`5`		`- const array = originalArray.slice(0);`
	`5`	`+ const array = [...originalArray];`
`6`	`6`
`7`	`7`	`// Go through all array elements...`
`8`	`8`	`for (let i = 0; i < array.length; i += 1) {`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ import Sort from '../Sort';`
`3`	`3`	`export default class QuickSort extends Sort {`
`4`	`4`	`sort(originalArray) {`
`5`	`5`	`// Clone original array to prevent it from modification.`
`6`		`- const array = originalArray.slice(0);`
	`6`	`+ const array = [...originalArray];`
`7`	`7`
`8`	`8`	`// If array has less then or equal to one elements then it is already sorted.`
`9`	`9`	`if (array.length <= 1) {`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ import Sort from '../Sort';`
`3`	`3`	`export default class SelectionSort extends Sort {`
`4`	`4`	`sort(originalArray) {`
`5`	`5`	`// Clone original array to prevent its modification.`
`6`		`- const array = originalArray.slice(0);`
	`6`	`+ const array = [...originalArray];`
`7`	`7`
`8`	`8`	`for (let i = 0; i < array.length - 1; i += 1) {`
`9`	`9`	`let minIndex = i;`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ import Sort from '../Sort';`
`3`	`3`	`export default class ShellSort extends Sort {`
`4`	`4`	`sort(originalArray) {`
`5`	`5`	`// Prevent original array from mutations.`
`6`		`- const array = originalArray.slice(0);`
	`6`	`+ const array = [...originalArray];`
`7`	`7`
`8`	`8`	`// Define a gap distance.`
`9`	`9`	`let gap = Math.floor(array.length / 2);`

Comments

(0)