Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add tests ensuring minimum eslint peer dependency version is compatible with our rules #22

Open
@lshearer

Description

We specify eslint as a peer dependency of eslint-config-hudl, but there are a few issues:

  • The version in peerDependencies differs from that in devDependencies, so the version tests are run with does not fall in the same version range.
  • There is no maximum version currently on the peer dependency
  • The dev dependency uses ^, so it will install the latest compatible. We should be testing against the earliest.

Solution:

  • Change the peer dependency to have a max value (or use ^ form)
  • Set the dev dependency to be exactly equal to the minimum version satisfying the peer dependency
  • Add tests to ensure these values stay in sync

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /