Commit ec94da2

committed

Also apply Bin 1 check to filter. It makes it 20% faster

1 parent 2f1eebc commit ec94da2Copy full SHA for ec94da2

File tree

-0

lines changed

-0

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,8 @@ main = do`
`27`	`27`	`, bench "lookup present" $ whnf (lookup evens) m_even`
`28`	`28`	`, bench "map" $ whnf (M.map (+ 1)) m`
`29`	`29`	`, bench "map really" $ nf (M.map (+ 2)) m`
	`30`	`+ , bench "filter" $ whnf (M.filter even) m`
	`31`	`+ , bench "filter really" $ nf (M.filter even) m`
`30`	`32`	`, bench "<$" $ whnf ((1 :: Int) <$) m`
`31`	`33`	`, bench "<$ really" $ nf ((2 :: Int) <$) m`
`32`	`34`	`, bench "alterF lookup absent" $ whnf (atLookup evens) m_odd`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2966,6 +2966,9 @@ filter p m`
`2966`	`2966`
`2967`	`2967`	`filterWithKey :: (k -> a -> Bool) -> Map k a -> Map k a`
`2968`	`2968`	`filterWithKey _ Tip = Tip`
	`2969`	`+filterWithKey p t@(Bin 1 kx x _ _)`
	`2970`	`+ \| p kx x = t`
	`2971`	`+ \| otherwise = Tip`
`2969`	`2972`	`filterWithKey p t@(Bin _ kx x l r)`
`2970`	`2973`	\| p kx x = if pl `ptrEq` l && pr `ptrEq` r
`2971`	`2974`	`then t`
`@@ -2978,6 +2981,8 @@ filterWithKey p t@(Bin _ kx x l r)`
`2978`	`2981`	`-- predicate.`
`2979`	`2982`	`filterWithKeyA :: Applicative f => (k -> a -> f Bool) -> Map k a -> f (Map k a)`
`2980`	`2983`	`filterWithKeyA _ Tip = pure Tip`
	`2984`	`+filterWithKeyA p t@(Bin 1 kx x _ _) =`
	`2985`	`+ fmap (bool Tip t) (p kx x)`
`2981`	`2986`	`filterWithKeyA p t@(Bin _ kx x l r) =`
`2982`	`2987`	`liftA3 combine (filterWithKeyA p l) (p kx x) (filterWithKeyA p r)`
`2983`	`2988`	`where`

Comments

(0)