Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 12d1ead

Browse files
Add payload length validation to ping and pong
1 parent 206d2d5 commit 12d1ead

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

‎src/main/java/dev/gustavoavila/websocketclient/WebSocketClient.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -499,8 +499,11 @@ public void run() {
499499
* @param data Data to be sent, or null if there is no data.
500500
*/
501501
public void sendPing(byte[] data) {
502-
final Payload payload = new Payload(OPCODE_PING, data);
502+
if (data != null && data.length > 125) {
503+
throw new IllegalArgumentException("Control frame payload cannot be greater than 125 bytes");
504+
}
503505

506+
final Payload payload = new Payload(OPCODE_PING, data);
504507
new Thread(new Runnable() {
505508
@Override
506509
public void run() {
@@ -515,8 +518,11 @@ public void run() {
515518
* @param data Data to be sent, or null if there is no data.
516519
*/
517520
public void sendPong(byte[] data) {
518-
final Payload payload = new Payload(OPCODE_PONG, data);
521+
if (data != null && data.length > 125) {
522+
throw new IllegalArgumentException("Control frame payload cannot be greater than 125 bytes");
523+
}
519524

525+
final Payload payload = new Payload(OPCODE_PONG, data);
520526
new Thread(new Runnable() {
521527
@Override
522528
public void run() {

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /