-
Notifications
You must be signed in to change notification settings - Fork 47
-
I noticed that the project has a GraphQL endpoint.
I'm a big fan of GraphQL for locked down aka (white listed queries). I'm not a fan of it for ad-hoc queries because It's typically easy to construct queries that can DOS your app. So do we have any strategies to mitigate this issue?
Beta Was this translation helpful? Give feedback.
All reactions
Replies: 5 comments 5 replies
-
that can DOS your app.
Hijacking the discussion. Recently I found this commit and I am a bit afraid if someone can upload hand-crafted SBOMs and then initiate delete operation with an intention to DOS application on the worst gc performance scenario? Based on theory, a (directed) graph with N nodes can have at most N*N edges so traversing such a graph-like data structure, like the one stored in Postgres database, may also require N*N operations. On the other hand the same number of operations can be probably needed when storing a sinister SBOMs to the database so my concerns are probably just a false alarm. What do you think?
Beta Was this translation helpful? Give feedback.
All reactions
-
Can we close this?
Beta Was this translation helpful? Give feedback.
All reactions
-
I think it's still a valid one.
Beta Was this translation helpful? Give feedback.
All reactions
-
👍 1
-
I guess they don't have rate-limiter implemented yet
async-graphql/async-graphql#1618
https://docs.rs/async-graphql/latest/async_graphql/?search=limit
Beta Was this translation helpful? Give feedback.
All reactions
-
Created this issue #1228
(not saying that I'm going to do this -- right now)
Beta Was this translation helpful? Give feedback.
All reactions
-
So do we have any strategies to mitigate this issue?
The issue title includes "investigate." I don't want to imply that rate-limiting is the ideal solution, but we need alternatives for mitigation 👍
Beta Was this translation helpful? Give feedback.
All reactions
-
as a 'ping' I closed the issue and marked as invalid 👍
Beta Was this translation helpful? Give feedback.