Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Locking down the GraphQL endpoint #642

chirino started this conversation in General
Aug 6, 2024 · 5 comments · 5 replies
Discussion options

I noticed that the project has a GraphQL endpoint.

I'm a big fan of GraphQL for locked down aka (white listed queries). I'm not a fan of it for ad-hoc queries because It's typically easy to construct queries that can DOS your app. So do we have any strategies to mitigate this issue?

You must be logged in to vote

Replies: 5 comments 5 replies

Comment options

that can DOS your app.

Hijacking the discussion. Recently I found this commit and I am a bit afraid if someone can upload hand-crafted SBOMs and then initiate delete operation with an intention to DOS application on the worst gc performance scenario? Based on theory, a (directed) graph with N nodes can have at most N*N edges so traversing such a graph-like data structure, like the one stored in Postgres database, may also require N*N operations. On the other hand the same number of operations can be probably needed when storing a sinister SBOMs to the database so my concerns are probably just a false alarm. What do you think?

You must be logged in to vote
0 replies
Comment options

Can we close this?

You must be logged in to vote
1 reply
Comment options

ctron Feb 3, 2025
Maintainer

I think it's still a valid one.

Comment options

You must be logged in to vote
0 replies
Comment options

Created this issue #1228
(not saying that I'm going to do this -- right now)

You must be logged in to vote
2 replies
Comment options

So do we have any strategies to mitigate this issue?

The issue title includes "investigate." I don't want to imply that rate-limiting is the ideal solution, but we need alternatives for mitigation 👍

Comment options

as a 'ping' I closed the issue and marked as invalid 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet

AltStyle によって変換されたページ (->オリジナル) /