Commit c317bcf

iwanbkunknwon

authored and

committed

Split Client.getResponse to Client.doRequest & Client.getResponse. (#44)

There is some API that give empty response and we only need to check HTTP status code. example : https://developer.github.com/v3/issues/assignees/#check-assignee But there is no way to do this in current code because getResponse will parse the response body and not returning HTTP status code. Client.doRequest makes it possible to do this.

1 parent c52f7ee commit c317bcfCopy full SHA for c317bcf

File tree

1 file changed

-2

lines changed

gogs.go

1 file changed

-2

lines changed

`‎gogs.go`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ func (c Client) SetHTTPClient(client http.Client) {`
`38`	`38`	`c.client = client`
`39`	`39`	`}`
`40`	`40`
`41`		`-func (c *Client) getResponse(method, path string, header http.Header, body io.Reader) ([]byte, error) {`
	`41`	`+func (c Client) doRequest(method, path string, header http.Header, body io.Reader) (http.Response, error) {`
`42`	`42`	`req, err := http.NewRequest(method, c.url+"/api/v1"+path, body)`
`43`	`43`	`if err != nil {`
`44`	`44`	`return nil, err`
`@@ -48,7 +48,11 @@ func (c *Client) getResponse(method, path string, header http.Header, body io.Re`
`48`	`48`	`req.Header[k] = v`
`49`	`49`	`}`
`50`	`50`
`51`		`- resp, err := c.client.Do(req)`
	`51`	`+ return c.client.Do(req)`
	`52`	`+}`
	`53`	`+`
	`54`	`+func (c *Client) getResponse(method, path string, header http.Header, body io.Reader) ([]byte, error) {`
	`55`	`+ resp, err := c.doRequest(method, path, header, body)`
`52`	`56`	`if err != nil {`
`53`	`57`	`return nil, err`
`54`	`58`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit c317bcf

File tree

1 file changed

1 file changed

`‎gogs.go`

0 commit comments