Commit e02b809

elonnzhangelonnzhangmethane

authored

ColumnTypeScanType() returns sql.Null[uint64] for bigint unsigned (#1612)

Co-authored-by: elonnzhang <elonnzhang@tencent.com> Co-authored-by: Inada Naoki <songofacandy@gmail.com>

1 parent c786d41 commit e02b809Copy full SHA for e02b809

File tree

2 files changed

-3

lines changed

AUTHORS
fields.go

2 files changed

-3

lines changed

`‎AUTHORS`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,8 @@ Alex Snast <alexsn at fb.com>`
`18`	`18`	`Alexey Palazhchenko <alexey.palazhchenko at gmail.com>`
`19`	`19`	`Andrew Reid <andrew.reid at tixtrack.com>`
`20`	`20`	`Animesh Ray <mail.rayanimesh at gmail.com>`
`21`		`-Arne Hormann <arnehormann at gmail.com>`
`22`	`21`	`Ariel Mashraki <ariel at mashraki.co.il>`
	`22`	`+Arne Hormann <arnehormann at gmail.com>`
`23`	`23`	`Artur Melanchyk <artur.melanchyk@gmail.com>`
`24`	`24`	`Asta Xie <xiemengjun at gmail.com>`
`25`	`25`	`B Lamarche <blam413 at gmail.com>`
`@@ -65,6 +65,7 @@ Jeff Hodges <jeff at somethingsimilar.com>`
`65`	`65`	`Jeffrey Charles <jeffreycharles at gmail.com>`
`66`	`66`	`Jennifer Purevsuren <jennifer at dolthub.com>`
`67`	`67`	`Jerome Meyer <jxmeyer at gmail.com>`
	`68`	`+Jiabin Zhang <jiabin.z at qq.com>`
`68`	`69`	`Jiajia Zhong <zhong2plus at gmail.com>`
`69`	`70`	`Jian Zhen <zhenjl at gmail.com>`
`70`	`71`	`Joe Mann <contact at joemann.co.uk>`
`@@ -84,10 +85,11 @@ Linh Tran Tuan <linhduonggnu at gmail.com>`
`84`	`85`	`Lion Yang <lion at aosc.xyz>`
`85`	`86`	`Luca Looz <luca.looz92 at gmail.com>`
`86`	`87`	`Lucas Liu <extrafliu at gmail.com>`
`87`		`-Lunny Xiao <xiaolunwen at gmail.com>`
`88`	`88`	`Luke Scott <luke at webconnex.com>`
	`89`	`+Lunny Xiao <xiaolunwen at gmail.com>`
`89`	`90`	`Maciej Zimnoch <maciej.zimnoch at codilime.com>`
`90`	`91`	`Michael Woolnough <michael.woolnough at gmail.com>`
	`92`	`+Minh Quang <minhquang4334 at gmail.com>`
`91`	`93`	`Nao Yokotsuka <yokotukanao at gmail.com>`
`92`	`94`	`Nathanial Murphy <nathanial.murphy at gmail.com>`
`93`	`95`	`Nicola Peduzzi <thenikso at gmail.com>`
`@@ -98,7 +100,6 @@ Paul Bonser <misterpib at gmail.com>`
`98`	`100`	`Paulius Lozys <pauliuslozys at gmail.com>`
`99`	`101`	`Peter Schultz <peter.schultz at classmarkets.com>`
`100`	`102`	`Phil Porada <philporada at gmail.com>`
`101`		`-Minh Quang <minhquang4334 at gmail.com>`
`102`	`103`	`Rebecca Chin <rchin at pivotal.io>`
`103`	`104`	`Reed Allman <rdallman10 at gmail.com>`
`104`	`105`	`Richard Wilkes <wilkes at me.com>`

`‎fields.go`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,7 @@ var (`
`128`	`128`	`scanTypeInt64 = reflect.TypeOf(int64(0))`
`129`	`129`	`scanTypeNullFloat = reflect.TypeOf(sql.NullFloat64{})`
`130`	`130`	`scanTypeNullInt = reflect.TypeOf(sql.NullInt64{})`
	`131`	`+ scanTypeNullUint = reflect.TypeOf(sql.Null[uint64]{})`
`131`	`132`	`scanTypeNullTime = reflect.TypeOf(sql.NullTime{})`
`132`	`133`	`scanTypeUint8 = reflect.TypeOf(uint8(0))`
`133`	`134`	`scanTypeUint16 = reflect.TypeOf(uint16(0))`
`@@ -185,6 +186,9 @@ func (mf *mysqlField) scanType() reflect.Type {`
`185`	`186`	`}`
`186`	`187`	`return scanTypeInt64`
`187`	`188`	`}`
	`189`	`+ if mf.flags&flagUnsigned != 0 {`
	`190`	`+ return scanTypeNullUint`
	`191`	`+ }`
`188`	`192`	`return scanTypeNullInt`
`189`	`193`
`190`	`194`	`case fieldTypeFloat:`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit e02b809

File tree

2 files changed

2 files changed

`‎AUTHORS`

`‎fields.go`

0 commit comments