-
-
Notifications
You must be signed in to change notification settings - Fork 954
Closed
Labels
Milestone
@apatard
Description
Using a pathspec like ':!foo' as argument to repo.is_dirty() will result in :
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
cmdline: git diff --cached --abbrev=40 --full-index --raw :!foo
stderr: 'fatal: ambiguous argument '!foo': unknown revision or path not in the working tree.
The code should be adding a -- before the path to avoid any ambiguity. For instance, like that:
if path:
default_args.append('--')
default_args.append(path)