Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fetch progress information is available but dropped #1466

jorhett started this conversation in General
Discussion options

Modern versions of git will return progress information. In debugging what goes on here, I found that all of the information was being dropped by _parse_line. For others who run into this, I was able to return branch update information to the user by adding the following:

class SeeFetchProgress(git.remote.RemoteProgress):
 # the implementation of RemoteProgress currently doesn't match fetch lines, so catch them when dropped.
 def line_dropped(self, line: str):
 if re.match('remote: ', line):
 return
 print(line)
You must be logged in to vote

Replies: 1 comment 2 replies

Comment options

Indeed, the mechanism is meant to be used to obtain additional information, with the default implementation being somewhat limited.

This discussion could be used to figure out if the default implementation should be improved, if there should be better docs, or anything else related to improving the situation.

You must be logged in to vote
2 replies
Comment options

As shown by my change, I believe that the lines other than remote: can be useful and necessary... in fact, we wouldn't be able to use this module without the ability to display those lines as they are necessary and critical output to understand the actions taken (or not)

So yes, I firmly believe that this would be much more useful if one could retrieve these lines, hopefully from the API as a String and not by overloading a function.

Comment options

The current architecture should support intercepting all information and transforming it into anything as desired. PRs are definitely welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
Converted from issue

This discussion was converted from issue #1465 on July 16, 2022 02:26.

AltStyle によって変換されたページ (->オリジナル) /