-
-
Notifications
You must be signed in to change notification settings - Fork 954
Commit d0868bd
committed
Remove deprecated license classifier
GitPython project metadata specify the project's license primarily
through the value of `license`, currently passed as an argument to
`setuptools.setup`, which holds the string `"BSD-3-Clause"`. This
is an SPDX license identifier readily understood by both humans and
machines.
The PyPI trove classifier "License :: OSI Approved :: BSD License"
has also been specified in `setup.py`. However, this is not ideal,
because:
1. It does not identify a specific license. There are multiple
"BSD" licenses in use, with BSD-2-Clause and BSD-3-Clause both
in very wide use.
2. It is no longer recommended to use a trove classifier to
indicate a license. The use of license classifiers (even
unambiguous ones) has been deprecated. See:
- https://packaging.python.org/en/latest/specifications/core-metadata/#classifier-multiple-use
- https://peps.python.org/pep-0639/#deprecate-license-classifiers
This commit removes the classifier. The license itself is of course
unchanged, as is the `license` value of `"BSD-3-Clause"`.
(An expected effect of this change is that, starting in the next
release of GitPython, PyPI may show "License: BSD-3-Clause" instead
of the current text "License: BSD License (BSD-3-Clause)".)
This change fixes a warning issued by a subprocess of `pip` when
installing the package. The warning, until this change, could be
observed by running `pip install . -v` or `pip install -e . -v` and
examining the verbose output, or by running `pip install .` or
`pip install -e .` with the `PYTHONWARNINGS` environment variable
set to `error`:
SetuptoolsDeprecationWarning: License classifiers are deprecated.
!!
********************************************************************************
Please consider removing the following classifiers in favor of a SPDX license expression:
License :: OSI Approved :: BSD License
See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
********************************************************************************
!!
(In preceding commits, `test_installation` has been augmented to
set that environment variable, surfacing the error. This change
should allow that test to pass, unless it finds other problems.)1 parent 6826b59 commit d0868bd
1 file changed
+0
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | - | ||
99 | 98 | | |
100 | 99 | | |
101 | 100 | | |
| |||
0 commit comments