Commit c09ac1a

committed

Test InvalidGitRepositoryError in repo subdir

A Repo object can of course be constructed from a path to a directory that is the root of an existing repository, and raises InvalidGitRepositoryError on a directory that is outside of any repository. Tests intended to show both conditions already exist. This adds a test to verify that InvalidGitRepositoryError is also raised when an attempt is made to construct a Repo object from a path to a directory that is not the root of a repository but that is known to be located inside an existing git repository.

1 parent 9277ff5 commit c09ac1aCopy full SHA for c09ac1a

File tree

1 file changed

+12

-1

lines changed

test
- test_repo.py

1 file changed

+12

-1

lines changed

`‎test/test_repo.py‎`

Lines changed: 12 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -77,9 +77,20 @@ def tearDown(self):`
`77`	`77`	`gc.collect()`
`78`	`78`
`79`	`79`	`def test_new_should_raise_on_invalid_repo_location(self):`
	`80`	`+ # Ideally this tests a directory that is outside of any repository. In the rare`
	`81`	`+ # case tempfile.gettempdir() is inside a repo, this still passes, but tests the`
	`82`	`+ # same scenario as test_new_should_raise_on_invalid_repo_location_within_repo.`
`80`	`83`	`with tempfile.TemporaryDirectory() as tdir:`
`81`	`84`	`self.assertRaises(InvalidGitRepositoryError, Repo, tdir)`
`82`	`85`
	`86`	`+ @with_rw_directory`
	`87`	`+ def test_new_should_raise_on_invalid_repo_location_within_repo(self, rw_dir):`
	`88`	`+ repo_dir = osp.join(rw_dir, "repo")`
	`89`	`+ Repo.init(repo_dir)`
	`90`	`+ subdir = osp.join(repo_dir, "subdir")`
	`91`	`+ os.mkdir(subdir)`
	`92`	`+ self.assertRaises(InvalidGitRepositoryError, Repo, subdir)`
	`93`	`+`
`83`	`94`	`def test_new_should_raise_on_non_existent_path(self):`
`84`	`95`	`with tempfile.TemporaryDirectory() as tdir:`
`85`	`96`	`nonexistent = osp.join(tdir, "foobar")`
`@@ -122,7 +133,7 @@ def test_tree_from_revision(self):`
`122`	`133`	`self.assertEqual(tree.type, "tree")`
`123`	`134`	`self.assertEqual(self.rorepo.tree(tree), tree)`
`124`	`135`
`125`		`- # try from invalid revision that does not exist`
	`136`	`+ # Try from an invalid revision that does not exist.`
`126`	`137`	`self.assertRaises(BadName, self.rorepo.tree, "hello world")`
`127`	`138`
`128`	`139`	`def test_pickleable(self):`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit c09ac1a

File tree

1 file changed

1 file changed

`‎test/test_repo.py‎`

0 commit comments