Commit bfae362

authored

Merge pull request #686 from jeblair/issue-605

Only gc.collect() under windows

2 parents 4dd14b6 + 454feda commit bfae362Copy full SHA for bfae362

File tree

+10

-2

lines changed

+10

-2

lines changed

Lines changed: 10 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -209,9 +209,17 @@ def __del__(self):`
`209`	`209`	`def close(self):`
`210`	`210`	`if self.git:`
`211`	`211`	`self.git.clear_cache()`
`212`		`- gc.collect()`
	`212`	`+ # Tempfiles objects on Windows are holding references to`
	`213`	`+ # open files until they are collected by the garbage`
	`214`	`+ # collector, thus preventing deletion.`
	`215`	`+ # TODO: Find these references and ensure they are closed`
	`216`	`+ # and deleted synchronously rather than forcing a gc`
	`217`	`+ # collection.`
	`218`	`+ if is_win:`
	`219`	`+ gc.collect()`
`213`	`220`	`gitdb.util.mman.collect()`
`214`		`- gc.collect()`
	`221`	`+ if is_win:`
	`222`	`+ gc.collect()`
`215`	`223`
`216`	`224`	`def __eq__(self, rhs):`
`217`	`225`	`if isinstance(rhs, Repo):`

Comments

(0)