Commit ab95886

committed

Eliminate istream_ok variable

In Git.execute, the stdin argument to Popen is the only one where a compound expression (rather than a single term) is currently passed. So having that be the same in the log message makes it easier to understand what is going on, as well as to see how the information shown in the log corresponds to what Popen receives.

1 parent c3fde7f commit ab95886Copy full SHA for ab95886

File tree

1 file changed

-4

lines changed

git
- cmd.py

1 file changed

-4

lines changed

`‎git/cmd.py‎`

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -973,16 +973,13 @@ def execute(`
`973`	`973`	`# end handle`
`974`	`974`
`975`	`975`	`stdout_sink = PIPE if with_stdout else getattr(subprocess, "DEVNULL", None) or open(os.devnull, "wb")`
`976`		`- istream_ok = "None"`
`977`		`- if istream:`
`978`		`- istream_ok = "<valid stream>"`
`979`	`976`	`if shell is None:`
`980`	`977`	`shell = self.USE_SHELL`
`981`	`978`	`log.debug(`
`982`	`979`	`"Popen(%s, cwd=%s, stdin=%s, shell=%s, universal_newlines=%s)",`
`983`	`980`	`redacted_command,`
`984`	`981`	`cwd,`
`985`		`- istream_ok,`
	`982`	`+ "<valid stream>"ifistreamelse"None",`
`986`	`983`	`shell,`
`987`	`984`	`universal_newlines,`
`988`	`985`	`)`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit ab95886

File tree

1 file changed

1 file changed

`‎git/cmd.py‎`

0 commit comments