Commit 5cf7f97

committed

Fix non-venv branch always failing

cc202cc put an end to the problem where, when run outside a virtual environment, it would always "succeed", because all "|| echo ..." required to succeed was for the echo command reporting the error to succeed. Unfortunately, that commit created the oppposite problem, causing that case to always fail! This commit fixes it, so it fails when there is an error, and succeeds when there is no error.

1 parent f5da163 commit 5cf7f97Copy full SHA for 5cf7f97

File tree

1 file changed

-2

lines changed

Makefile

1 file changed

-2

lines changed

`‎Makefile‎`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,7 @@ force_release: clean`
`43`	`43`	`python -m build --sdist --wheel; \`
`44`	`44`	`else \`
`45`	`45`	`python3 -m build --sdist --wheel \|\| \`
`46`		`- echo "Use a virtual-env with 'python -m venv env && source env/bin/activate' instead" && \`
`47`		`- false; \`
	`46`	`+ { echo "Use a virtual-env with 'python -m venv env && source env/bin/activate' instead" && false; }; \`
`48`	`47`	`fi`
`49`	`48`
`50`	`49`	`# Upload to PyPI and push the tag.`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 5cf7f97

File tree

1 file changed

1 file changed

`‎Makefile‎`

0 commit comments