Commit 39f12bd

authored

Do not call get_user_id if it is not needed

On systems without any environment variables and no pwd module, gitpython crashes as it tries to read the environment variable before looking at its config.

1 parent d8a6398 commit 39f12bdCopy full SHA for 39f12bd

File tree

1 file changed

-1

lines changed

git
- util.py

1 file changed

-1

lines changed

`‎git/util.py‎`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -704,7 +704,11 @@ def default_name() -> str:`
`704`	`704`	`setattr(actor, attr, val)`
`705`	`705`	`except KeyError:`
`706`	`706`	`if config_reader is not None:`
`707`		`- setattr(actor, attr, config_reader.get_value('user', cvar, default()))`
	`707`	`+ try:`
	`708`	`+ val = config_reader.get_value('user', cvar)`
	`709`	`+ except Exception:`
	`710`	`+ val = default()`
	`711`	`+ setattr(actor, attr, val)`
`708`	`712`	`# END config-reader handling`
`709`	`713`	`if not getattr(actor, attr):`
`710`	`714`	`setattr(actor, attr, default())`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 39f12bd

File tree

1 file changed

1 file changed

`‎git/util.py‎`

0 commit comments