Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 361854d

Browse files
yarikopticankostis
authored andcommitted
TST: Add test for removing submodule with remotes without refs
1 parent 6497d1e commit 361854d

File tree

1 file changed

+20
-2
lines changed

1 file changed

+20
-2
lines changed

‎git/test/test_submodule.py‎

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,8 +317,8 @@ def _do_base_tests(self, rwrepo):
317317
# forcibly delete the child repository
318318
prev_count = len(sm.children())
319319
self.failUnlessRaises(ValueError, csm.remove, force=True)
320-
# We removed sm, which removed all submodules. Howver, the instance we have
321-
# still points to the commit prior to that, where it still existed
320+
# We removed sm, which removed all submodules. However, the instance we
321+
# have still points to the commit prior to that, where it still existed
322322
csm.set_parent_commit(csm.repo.commit(), check=False)
323323
assert not csm.exists()
324324
assert not csm.module_exists()
@@ -801,6 +801,24 @@ def assert_exists(sm, value=True):
801801
assert os.path.isdir(sm_module_path) == dry_run
802802
# end for each dry-run mode
803803

804+
@with_rw_directory
805+
def test_remove_norefs(self, rwdir):
806+
parent = git.Repo.init(os.path.join(rwdir, 'parent'))
807+
sm_name = 'mymodules/myname'
808+
sm = parent.create_submodule(sm_name, sm_name, url=self._small_repo_url())
809+
assert sm.exists()
810+
811+
parent.index.commit("Added submodule")
812+
813+
assert sm.repo is parent # yoh was surprised since expected sm repo!!
814+
# so created a new instance for submodule
815+
smrepo = git.Repo(os.path.join(rwdir, 'parent', sm.path))
816+
# Adding a remote without fetching so would have no references
817+
smrepo.create_remote('special', 'git@server-shouldnotmatter:repo.git')
818+
# And we should be able to remove it just fine
819+
sm.remove()
820+
assert not sm.exists()
821+
804822
@with_rw_directory
805823
def test_rename(self, rwdir):
806824
parent = git.Repo.init(os.path.join(rwdir, 'parent'))

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /