Commit 97a9616

author

Hariharan Subramanian

committed

Converted Answer client to similar response model ✅

1 parent b8bee7c commit 97a9616Copy full SHA for 97a9616

File tree

2 files changed

+16

-17

lines changed

StackExchange.NET/StackExchange.NET
- Clients
  - Answers.cs
- Interfaces
  - IAnswers.cs

2 files changed

+16

-17

lines changed

`‎StackExchange.NET/StackExchange.NET/Clients/Answers.cs`

Lines changed: 12 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@`
`3`	`3`	`using System;`
`4`	`4`	`using System.Collections.Generic;`
`5`	`5`	`using System.Web;`
`6`		`-using Newtonsoft.Json;`
`7`	`6`	`using StackExchange.NET.Interfaces;`
`8`	`7`	`using StackExchange.NET.Models;`
`9`	`8`
`@@ -14,48 +13,48 @@ namespace StackExchange.NET.Clients`
`14`	`13`	`public partial class StackExchangeClient : IAnswers`
`15`	`14`	`{`
`16`	`15`	`public IAnswers Answers => this;`
`17`		`- Answers IAnswers.GetAllAnswers(AnswerFilters filters)`
	`16`	`+ BaseResponse<Answers> IAnswers.GetAllAnswers(AnswerFilters filters)`
`18`	`17`	`{`
`19`	`18`	`if (filters == null)`
`20`	`19`	`throw new ArgumentNullException($"Null is not a valid parameter");`
`21`	`20`	`var apiParams = filters.GetQueryParams();`
`22`	`21`	`var url = $"{_baseApiUrl}/answers?key={_apiKey}&{apiParams}";`
`23`	`22`	`var response = _httpClient.GetAsync(url).Result.Content.ReadAsStringAsync().Result;`
`24`		`- var answers = JsonConvert.DeserializeObject<Answers>(response);`
`25`		`- return answers;`
	`23`	`+ var apiResult = response.DeserializeJson<Data<Answers>>().ValidateApiResponse();`
	`24`	`+ return apiResult;`
`26`	`25`	`}`
`27`	`26`
`28`		`- Answers IAnswers.GetAnswerByIds(List<string> ids, AnswerFilters filters)`
	`27`	`+ BaseResponse<Answers> IAnswers.GetAnswerByIds(List<string> ids, AnswerFilters filters)`
`29`	`28`	`{`
`30`	`29`	`var apiParams = filters.GetQueryParams();`
`31`	`30`	`var url = $"{_baseApiUrl}/answers/";`
`32`	`31`	`var idsToEncode = string.Join(";", ids.ToArray());`
`33`	`32`	`url = url + $"{HttpUtility.UrlEncode(idsToEncode)}" + $"?key={_apiKey}&{apiParams}";`
`34`	`33`	`var response = _httpClient.GetAsync(url).Result.Content.ReadAsStringAsync().Result;`
`35`		`- var answers = JsonConvert.DeserializeObject<Answers>(response);`
`36`		`- return answers;`
	`34`	`+ var apiResult = response.DeserializeJson<Data<Answers>>().ValidateApiResponse();`
	`35`	`+ return apiResult;`
`37`	`36`	`}`
`38`	`37`
`39`		`- Answers IAnswers.GetCommentsByIds(List<string> ids, AnswerFilters filters)`
	`38`	`+ BaseResponse<Answers> IAnswers.GetCommentsByIds(List<string> ids, AnswerFilters filters)`
`40`	`39`	`{`
`41`	`40`	`var apiParams = filters.GetQueryParams();`
`42`	`41`	`var url = $"{_baseApiUrl}/answers/";`
`43`	`42`	`var idsToEncode = string.Join(";", ids.ToArray());`
`44`	`43`	`url = url + $"{HttpUtility.UrlEncode(idsToEncode)}" + $"/comments?key={_apiKey}&{apiParams}";`
`45`	`44`	`var response = _httpClient.GetAsync(url).Result.Content.ReadAsStringAsync().Result;`
`46`		`- var answers = JsonConvert.DeserializeObject<Answers>(response);`
`47`		`- return answers;`
	`45`	`+ var apiResult = response.DeserializeJson<Data<Answers>>().ValidateApiResponse();`
	`46`	`+ return apiResult;`
`48`	`47`	`}`
`49`	`48`
`50`		`- Questions IAnswers.GetQuestionByAnswerIds(List<string> ids, AnswerFilters filters)`
	`49`	`+ BaseResponse<Questions> IAnswers.GetQuestionByAnswerIds(List<string> ids, AnswerFilters filters)`
`51`	`50`	`{`
`52`	`51`	`var apiParams = filters.GetQueryParams();`
`53`	`52`	`var url = $"{_baseApiUrl}/answers/";`
`54`	`53`	`var idsToEncode = string.Join(";", ids.ToArray());`
`55`	`54`	`url = url + $"{HttpUtility.UrlEncode(idsToEncode)}" + $"/questions?key={_apiKey}&{apiParams}";`
`56`	`55`	`var response = _httpClient.GetAsync(url).Result.Content.ReadAsStringAsync().Result;`
`57`		`- var questions = JsonConvert.DeserializeObject<Questions>(response);`
`58`		`- return questions;`
	`56`	`+ var apiResult = response.DeserializeJson<Data<Questions>>().ValidateApiResponse();`
	`57`	`+ return apiResult;`
`59`	`58`	`}`
`60`	`59`
`61`	`60`	`void IAnswers.AcceptAnAnswer(string id, AnswerFilters filters)`

`‎StackExchange.NET/StackExchange.NET/Interfaces/IAnswers.cs`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,10 +5,10 @@ namespace StackExchange.NET.Interfaces`
`5`	`5`	`{`
`6`	`6`	`public interface IAnswers`
`7`	`7`	`{`
`8`		`- Answers GetAllAnswers(AnswerFilters filters);`
`9`		`- Answers GetAnswerByIds(List<string> ids, AnswerFilters filters);`
`10`		`- Answers GetCommentsByIds(List<string> ids, AnswerFilters filters);`
`11`		`- Questions GetQuestionByAnswerIds(List<string> ids, AnswerFilters filters);`
	`8`	`+ BaseResponse<Answers> GetAllAnswers(AnswerFilters filters);`
	`9`	`+ BaseResponse<Answers> GetAnswerByIds(List<string> ids, AnswerFilters filters);`
	`10`	`+ BaseResponse<Answers> GetCommentsByIds(List<string> ids, AnswerFilters filters);`
	`11`	`+ BaseResponse<Questions> GetQuestionByAnswerIds(List<string> ids, AnswerFilters filters);`
`12`	`12`	`void AcceptAnAnswer(string id, AnswerFilters filters);`
`13`	`13`	`void UndoAcceptedAnswer(string id, AnswerFilters filters);`
`14`	`14`	`void DeleteAnswer(string id, AnswerFilters filters);`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 97a9616

File tree

2 files changed

2 files changed

`‎StackExchange.NET/StackExchange.NET/Clients/Answers.cs`

`‎StackExchange.NET/StackExchange.NET/Interfaces/IAnswers.cs`

0 commit comments