Commit ef4890a

committed

Added Github auth and updated README

1 parent 17f41c7 commit ef4890aCopy full SHA for ef4890a

File tree

-1

lines changed

-1

lines changed

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,11 @@ For a detailed discussion of how Firestack works as well as how to contribute, c`
`16`	`16`	`* Covers lots of awesome features of Firebase:`
`17`	`17`	`* authentication`
`18`	`18`	`* username and password`
`19`		`- * social auth (implemented, but need to add providers)`
	`19`	`+ * social auth (implemented in conjunction with [react-native-oauth](https://github.com/fullstackreact/react-native-oauth))`
	`20`	`+ * Facebook`
	`21`	`+ * Github`
	`22`	`+ * Google`
	`23`	`+ * Twitter`
`20`	`24`	`* storage handling`
`21`	`25`	`* upload files`
`22`	`26`	`* download urls`
`@@ -25,6 +29,7 @@ For a detailed discussion of how Firestack works as well as how to contribute, c`
`25`	`29`	`* presence out-of-the-box`
`26`	`30`	`* analytics`
`27`	`31`	`* Remote configuration`
	`32`	`+ * FCM (in-progress)`
`28`	`33`	`* Redux support built-in (but not required)`
`29`	`34`	`* Android and iOS support`
`30`	`35`	`* Community supported and professionally backed`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -486,6 +486,9 @@ - (FIRAuthCredential )getCredentialForProvider:(NSString )provider`
`486`	`486`	`} else if ([provider compare:@"google" options:NSCaseInsensitiveSearch] == NSOrderedSame) {`
`487`	`487`	`credential = [FIRGoogleAuthProvider credentialWithIDToken:authToken`
`488`	`488`	`accessToken:authTokenSecret];`
	`489`	`+ } else if ([provider compare:@"github" options:NSCaseInsensitiveSearch] == NSOrderedSame) {`
	`490`	`+ credential = [FIRGitHubAuthProvider credentialWithIDToken:authToken`
	`491`	`+ accessToken:authTokenSecret];`
`489`	`492`	`} else {`
`490`	`493`	`NSLog(@"Provider not yet handled: %@", provider);`
`491`	`494`	`}`

Comments

(0)