Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Separate the dispatch internal state from the immutable Dispatch object #57

Open
Labels
part:actorAffects the dispatching actor part:dispatcherAffects the high-level dispatcher interface type:tech-debtImproves the project without visible changes for users
@llucax

Description

Since the Dispatch's deleted bool and running_state_change_synced are only attached as mutable properties for internal state tracking, it might make more sense to separate the state from the immutable dispatch, and have a DispatchState mutable class and a separate dict to map dispatch ID to its state, for example.

You can pass the state object to the Dispatch constructor and store it as a private property and expose read-only properties to access the state, if it needs to be accessed externally, and store the dict and mutate it from this actor only.

Originally posted by @llucax in #54 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    part:actorAffects the dispatching actor part:dispatcherAffects the high-level dispatcher interface type:tech-debtImproves the project without visible changes for users

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /