Commit 22e84fe

committed

fix(tests): do not look into full path for error metric

In order to collect all error metrics we're checking for "err" in the key name, which causes performance tests to fail because we added metrics called "intERRupts". Change the check to only look at the leaf of the path, so that when we have a metric such as `fc_metrics.net_metrics.cfg_fails`, we'll only be looking into `cfg_fails`. Suggested-by: Riccardo Mancini <mancio@amazon.co.uk> Signed-off-by: Babis Chalios <bchalios@amazon.es>

1 parent 2dab5e8 commit 22e84feCopy full SHA for 22e84fe

File tree

1 file changed

-1

lines changed

tests/host_tools
- fcmetrics.py

1 file changed

-1

lines changed

`‎tests/host_tools/fcmetrics.py‎`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -479,7 +479,10 @@ def flatten_dict(node, prefix: str):`
`479`	`479`	`failure_metrics = {`
`480`	`480`	`key: value`
`481`	`481`	`for key, value in flattened_metrics.items()`
`482`		`- if "err" in key or "fail" in key or "panic" in key or "num_faults" in key`
	`482`	`+ if "err" in key.split(".")[-1]`
	`483`	`+ or "fail" in key.split(".")[-1]`
	`484`	`+ or "panic" in key.split(".")[-1]`
	`485`	`+ or "num_faults" in key.split(".")[-1]`
`483`	`486`	`if value`
`484`	`487`	`if key not in ignored_failure_metrics`
`485`	`488`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 22e84fe

File tree

1 file changed

1 file changed

`‎tests/host_tools/fcmetrics.py‎`

0 commit comments