-
Notifications
You must be signed in to change notification settings - Fork 153
Open
@kriswest
Image
Description
Describe the bug
Pushes that end up in the error category can't be viewed in the admin UI if the diff step failed:
"lastStep": {
"logs": [
"diff - Executing \"git diff c338e9a0035b755f4f5c6fff00fa8b8f206d8c05 cee0c02d1cb4c22a7f014b370f00f83868a7c746\" in ./.remote/0000000000000000000000000000000000000000__cee0c02d1cb4c22a7f014b370f00f83868a7c746/fdc3.git",
"diff - Error: fatal: Invalid revision range c338e9a0035b755f4f5c6fff00fa8b8f206d8c05..cee0c02d1cb4c22a7f014b370f00f83868a7c746\n"
],
"id": "c5d80af9-465d-4e75-8d2a-47300261c034",
"stepName": "diff",
"content": null,
"error": true,
"errorMessage": "Error: fatal: Invalid revision range c338e9a0035b755f4f5c6fff00fa8b8f206d8c05..cee0c02d1cb4c22a7f014b370f00f83868a7c746\n",
"blocked": false,
"blockedMessage": null
}
This results in a white screen with no UI rendered.
To Reproduce
- Create a branch where the base is not in the upstream repo (e.g. create a branch, add some commits to it, then create a new branch from it, add commits to that and then try to push the result to the proxy)
- The proxy should reject the push, but add it to the error tab in the dashboard
- Attempt to view the diff.
Expected behavior
Details of the push should be displayed, including the error message, but with no Diff.