-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Finding that we're missing a nice modal construction (Header, body, footer). Would be a nice addition to the system (or let me know if it already exists!)
All reactions
-
❤️ 1
Replies: 1 comment
Right now the API looks something like this:
<Dialog>
<Layout
header={<DialogHeader />}
footer={...} />
{content}
</Layout>
</Dialog>
But I do think it's a bit hard to discover this construction. Internally we have a header prop directly on Dialog/Modal then later found that people had to recompose full layouts in panels, cards, and other surfaces (imagine a panel experience you want to display as a modal situationally).
Ideally, I think we could support both constructions.
In the composed layout form it's easier to reuse contents across multiple layouts. And in the dialog prop form it's much easier to find for the common case.
Curious how people are finding this and I'm happy to help spec something.