fix(core): StreamString performance improvements with large buffers (positional index instead of memory move) #11232

Original file line number	Diff line number	Diff line change
Expand Up		@@ -41,24 +41,15 @@ size_t StreamString::write(uint8_t data) {
		}

		int StreamString::available() {
	return length();
	return length() - _start;
		}

		int StreamString::read() {
	if (length()) {
	char c = charAt(0);
	remove(0, 1);
	return c;
	}
	return -1;
	return available() ? charAt(_start++) : -1;
		}

		int StreamString::peek() {
	if (length()) {
	char c = charAt(0);
	return c;
	}
	return -1;
	return available() ? charAt(_start) : -1;
		}

		void StreamString::flush() {}

4 changes: 4 additions & 0 deletions cores/esp32/StreamString.h

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -33,6 +33,10 @@ class StreamString : public Stream, public String {
		int read() override;
		int peek() override;
		void flush() override;

	private:
	// read position
	unsigned int _start = 0;
		};

		#endif /* STREAMSTRING_H_ */

Navigation Menu