Commit dd639c4

mmoneme-no-dev

authored and

committed

Fix wrong range of duty cycle (#1353)

The esp-idf expects duty values for the the sigma delta modulator in the range of -128 to 127 The arduino framework is supposed to use the range 0-255 thus the offset caclulation was wrong.

1 parent f14de5c commit dd639c4Copy full SHA for dd639c4

File tree

1 file changed

-2

lines changed

cores/esp32
- esp32-hal-sigmadelta.c

1 file changed

-2

lines changed

`‎cores/esp32/esp32-hal-sigmadelta.c‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ void sigmaDeltaWrite(uint8_t channel, uint8_t duty) //chan 0-7 duty 8 bit`
`60`	`60`	`if(channel > 7) {`
`61`	`61`	`return;`
`62`	`62`	`}`
`63`		`- duty += 128;`
	`63`	`+ duty -= 128;`
`64`	`64`	`SD_MUTEX_LOCK();`
`65`	`65`	`SIGMADELTA.channel[channel].duty = duty;`
`66`	`66`	`SD_MUTEX_UNLOCK();`
`@@ -72,7 +72,7 @@ uint8_t sigmaDeltaRead(uint8_t channel) //chan 0-7`
`72`	`72`	`return 0;`
`73`	`73`	`}`
`74`	`74`	`SD_MUTEX_LOCK();`
`75`		`- uint8_t duty = SIGMADELTA.channel[channel].duty - 128;`
	`75`	`+ uint8_t duty = SIGMADELTA.channel[channel].duty + 128;`
`76`	`76`	`SD_MUTEX_UNLOCK();`
`77`	`77`	`return duty;`
`78`	`78`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit dd639c4

File tree

1 file changed

1 file changed

`‎cores/esp32/esp32-hal-sigmadelta.c‎`

0 commit comments