Commit da72bc9

authored

eliminates error messages when using Ethernet Static IP (#5836)

Summary Only affects ETH (not WiFi) This PR solves #5733 by allowing the DHCP IDF server to complete its tasks and only then it sets a static IP. This also solves another related failure reported in this issue (#5733 (comment)). fix #5733 Impact Adds a delay in order to wait for DHCP to actually terminate before setting the static IP configuration in ETH.

1 parent 16a9cf7 commit da72bc9Copy full SHA for da72bc9

File tree

1 file changed

-1

lines changed

libraries/Ethernet/src
- ETH.cpp

1 file changed

-1

lines changed

`‎libraries/Ethernet/src/ETH.cpp‎`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -368,6 +368,10 @@ bool ETHClass::begin(uint8_t phy_addr, int power, int mdc, int mdio, eth_phy_typ`
`368`	`368`	`log_e("esp_eth_init error: %d", err);`
`369`	`369`	`}`
`370`	`370`	`#endif`
	`371`	`+ // holds a few microseconds to let DHCP start and enter into a good state`
	`372`	`+ // FIX ME -- adresses issue https://github.com/espressif/arduino-esp32/issues/5733`
	`373`	`+ delay(50);`
	`374`	`+`
`371`	`375`	`return true;`
`372`	`376`	`}`
`373`	`377`
`@@ -396,7 +400,8 @@ bool ETHClass::config(IPAddress local_ip, IPAddress gateway, IPAddress subnet, I`
`396`	`400`	`if(err != ERR_OK){`
`397`	`401`	`log_e("STA IP could not be configured! Error: %d", err);`
`398`	`402`	`return false;`
`399`		`-}`
	`403`	`+ }`
	`404`	`+`
`400`	`405`	`if(info.ip.addr){`
`401`	`406`	`staticIP = true;`
`402`	`407`	`} else {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit da72bc9

File tree

1 file changed

1 file changed

`‎libraries/Ethernet/src/ETH.cpp‎`

0 commit comments